From: Simon Marchi <simon.marchi@efficios.com>
To: gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@efficios.com>
Subject: [PATCH 06/15] Remove dict_empty/mdict_empty
Date: Mon, 25 Nov 2019 05:27:00 -0000 [thread overview]
Message-ID: <20191125052655.22696-7-simon.marchi@efficios.com> (raw)
In-Reply-To: <20191125052655.22696-1-simon.marchi@efficios.com>
These functions are not used in the code base, remove them.
gdb/ChangeLog:
* dictionary.c (dict_empty, mdict_empty): Remove.
* dictionary.c (mdict_empty): Remove.
Change-Id: I4c1b08c730f6790b2f3d28b680607618e3c08e48
---
gdb/dictionary.c | 24 ------------------------
gdb/dictionary.h | 4 ----
2 files changed, 28 deletions(-)
diff --git a/gdb/dictionary.c b/gdb/dictionary.c
index 939f32b59afb..0d13370b7269 100644
--- a/gdb/dictionary.c
+++ b/gdb/dictionary.c
@@ -508,16 +508,6 @@ dict_size (const struct dictionary *dict)
implemented generically by means of the vtable. Typically, they're
rarely used. */
-/* Test to see if DICT is empty. */
-
-static int
-dict_empty (struct dictionary *dict)
-{
- struct dict_iterator iter;
-
- return (dict_iterator_first (dict, &iter) == NULL);
-}
-
/* The functions implementing the dictionary interface. */
@@ -1283,17 +1273,3 @@ mdict_size (const struct multidictionary *mdict)
return size;
}
-
-/* See dictionary.h. */
-
-bool
-mdict_empty (const struct multidictionary *mdict)
-{
- for (unsigned short idx = 0; idx < mdict->n_allocated_dictionaries; ++idx)
- {
- if (!dict_empty (mdict->dictionaries[idx]))
- return false;
- }
-
- return true;
-}
diff --git a/gdb/dictionary.h b/gdb/dictionary.h
index e6481cd38ce9..9a7739b7c10d 100644
--- a/gdb/dictionary.h
+++ b/gdb/dictionary.h
@@ -93,10 +93,6 @@ extern void mdict_add_symbol (struct multidictionary *mdict,
extern void mdict_add_pending (struct multidictionary *mdict,
const struct pending *symbol_list);
-/* Is the multidictionary empty? */
-
-extern int mdict_empty (struct multidictionary *mdict);
-
/* A type containing data that is used when iterating over all symbols
in a dictionary. Don't ever look at its innards; this type would
be opaque if we didn't need to be able to allocate it on the
--
2.24.0
next prev parent reply other threads:[~2019-11-25 5:27 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-25 5:27 [PATCH 00/15] Enable -Wmissing-declarations diagnostic Simon Marchi
2019-11-25 5:27 ` [PATCH 13/15] Remove simulator_command declaration, make static Simon Marchi
2019-11-25 5:27 ` [PATCH 07/15] Remove unused overload of exit_inferior_silent Simon Marchi
2019-11-25 5:27 ` [PATCH 05/15] Make a bunch of functions static Simon Marchi
2019-11-25 5:27 ` [PATCH 11/15] Remove declaration of tui_set_var_cmd, make definition static Simon Marchi
2019-11-25 5:27 ` [PATCH 15/15] Enable -Wmissing-declarations diagnostic Simon Marchi
2019-11-25 22:06 ` Tom Tromey
2019-11-25 22:11 ` Simon Marchi
2019-11-26 14:12 ` Tom Tromey
2019-11-26 19:48 ` Simon Marchi
2019-11-25 5:27 ` [PATCH 03/15] Add missing includes in dwarf-index-write.c and mi/mi-interp.c Simon Marchi
2019-11-25 5:27 ` [PATCH 12/15] Make functions static in unittests Simon Marchi
2019-11-25 5:27 ` [PATCH 01/15] Add back declarations for _initialize functions Simon Marchi
2020-01-09 18:46 ` John Baldwin
2020-01-09 22:23 ` Simon Marchi
2020-01-09 22:33 ` Tom Tromey
2020-01-09 22:50 ` Simon Marchi
2020-01-10 18:43 ` Tom Tromey
2020-01-10 21:46 ` Simon Marchi
2019-11-25 5:27 ` Simon Marchi [this message]
2019-11-25 5:27 ` [PATCH 04/15] Remove unused function set_gdb_completion_word_break_characters Simon Marchi
2019-11-25 5:27 ` [PATCH 02/15] Include aarch32-tdep.h in aarch32-tdep.c Simon Marchi
2019-11-25 5:33 ` [PATCH 14/15] Fix declaration of sparc_xfer_wcookie Simon Marchi
2019-11-25 5:33 ` [PATCH 08/15] Remove info_terminal_command declaration, make definition static Simon Marchi
2019-11-25 5:33 ` [PATCH 09/15] Add declaration to python init func Simon Marchi
2019-11-25 5:33 ` [PATCH 10/15] Remove unused rbreak_command_wrapper and other declarations Simon Marchi
2019-11-25 22:08 ` [PATCH 00/15] Enable -Wmissing-declarations diagnostic Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191125052655.22696-7-simon.marchi@efficios.com \
--to=simon.marchi@efficios.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox