From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3012 invoked by alias); 9 Jan 2020 22:50:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3000 invoked by uid 89); 9 Jan 2020 22:50:42 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-10.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=agent X-HELO: mail.efficios.com Received: from mail.efficios.com (HELO mail.efficios.com) (167.114.142.138) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 09 Jan 2020 22:50:41 +0000 Received: from localhost (ip6-localhost [IPv6:::1]) by mail.efficios.com (Postfix) with ESMTP id CE3F7696E1C; Thu, 9 Jan 2020 17:50:39 -0500 (EST) Received: from mail.efficios.com ([IPv6:::1]) by localhost (mail02.efficios.com [IPv6:::1]) (amavisd-new, port 10032) with ESMTP id xgH6tGe72wbS; Thu, 9 Jan 2020 17:50:39 -0500 (EST) Received: from localhost (ip6-localhost [IPv6:::1]) by mail.efficios.com (Postfix) with ESMTP id 5FC44696E19; Thu, 9 Jan 2020 17:50:39 -0500 (EST) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.efficios.com 5FC44696E19 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=default; t=1578610239; bh=YriD6ApzcWENe9JLDuvM9InCxAtGvT9qtAUSOZt8KxM=; h=To:From:Message-ID:Date:MIME-Version; b=NULoevDssNuXO/q6rDVOZ5Dff9dYY9/Ajoz3qntVd+mDfRFMTR7sud1BqptWGR4/G UKGyqM45m64Nth5xbC8RnEuQUuOa7RdPzYUUDsb4lq+upKbfgXkZJiyQIa5LQVi4vg ylHNWiFTYzkPxYhZOQbiJKf/7QdfC/d6oUSev7GZEPN5d2b9Af+D0Sc4YuOMENNfuj gV7ptqGB0URCKRlxTQz/AEwW5xNki8AoNrkqJN4kqs0tLgSbkOPaxxbkTTHkztxLEs qa4ghUYCH60ztpEnsDpUGwbzx1oCtcoiR0P8J330lDIADJbgBKCqUynCa2/qgY4Aog 9IzhRbW+SS+Mw== Received: from mail.efficios.com ([IPv6:::1]) by localhost (mail02.efficios.com [IPv6:::1]) (amavisd-new, port 10026) with ESMTP id EF2mOhFP37Ce; Thu, 9 Jan 2020 17:50:39 -0500 (EST) Received: from [172.16.0.95] (192-222-181-218.qc.cable.ebox.net [192.222.181.218]) by mail.efficios.com (Postfix) with ESMTPSA id 39FBD696E0F; Thu, 9 Jan 2020 17:50:39 -0500 (EST) Subject: Re: [PATCH 01/15] Add back declarations for _initialize functions To: Tom Tromey Cc: John Baldwin , gdb-patches@sourceware.org References: <20191125052655.22696-1-simon.marchi@efficios.com> <20191125052655.22696-2-simon.marchi@efficios.com> <87a76wxntd.fsf@tromey.com> From: Simon Marchi Message-ID: <23b12f35-00ab-cf51-7aee-994652a688d1@efficios.com> Date: Thu, 09 Jan 2020 22:50:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <87a76wxntd.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2020-01/txt/msg00227.txt.bz2 On 2020-01-09 5:33 p.m., Tom Tromey wrote: >>>>>> "Simon" =3D=3D Simon Marchi writes: >=20 > Simon> And among those, the functions used both in the in-process agent > Simon> and in gdbserver itself are problematic, because they should be ex= ported when > Simon> built for the IPA, but static when built for gdbserver. So I gave= up on it > Simon> for the moment. This patch (01/15) would only be relevant if the = rest goes in > Simon> too, but I note your comment about clang. >=20 > Is it on a branch somewhere? Maybe it wouldn't be too hard to finish up. >=20 > Tom >=20 I have just uploaded it to the "missing-declarations" branch on my github: https://github.com/simark/binutils-gdb/tree/missing-declarations I have updated the patches slightly to account for the new unittests. So i= f you try to build, you'll stumble directly on the build error that made me give = up: /home/smarchi/src/binutils-gdb/gdb/gdbserver/tracepoint.c: In function =E2= =80=98void gdb_agent_stop_tracing()=E2=80=99: /home/smarchi/src/binutils-gdb/gdb/gdbserver/../gdbsupport/agent.h:29:36: e= rror: no previous declaration for =E2=80=98void gdb_agent_stop_tracing()=E2= =80=99 [-Werror=3Dmissing-declarations] #define IPA_SYM_EXPORTED_NAME(SYM) gdb_agent_ ## SYM ^ /home/smarchi/src/binutils-gdb/gdb/gdbserver/tracepoint.c:114:23: note: in = expansion of macro =E2=80=98IPA_SYM_EXPORTED_NAME=E2=80=99 # define stop_tracing IPA_SYM_EXPORTED_NAME (stop_tracing) ^~~~~~~~~~~~~~~~~~~~~ /home/smarchi/src/binutils-gdb/gdb/gdbserver/tracepoint.c:374:1: note: in e= xpansion of macro =E2=80=98stop_tracing=E2=80=99 stop_tracing (void) ^~~~~~~~~~~~ Simon