Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Kevin Buettner <kevinb@redhat.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tromey@adacore.com>
Subject: Re: [PATCH 1/2] Introduce ui_out::field_check_mark
Date: Tue, 13 May 2025 19:10:14 -0700	[thread overview]
Message-ID: <20250513191014.56a1b764@f42-zbm-amd> (raw)
In-Reply-To: <20250509-emoji-check-mark-v1-1-63b6c52411f3@adacore.com>

On Fri, 09 May 2025 14:18:50 -0600
Tom Tromey <tromey@adacore.com> wrote:

> This adds a new ui_out method, field_check_mark.  This method is to be
> used to indicate the "current" or "selected" row in a table.  This
> patch updates all the relevant tables to call this method.  No change
> should be expected.
> ---
>  gdb/ada-tasks.c         |  5 +----
>  gdb/inferior.c          |  6 +-----
>  gdb/linux-fork.c        |  5 +----
>  gdb/progspace.c         |  6 +-----
>  gdb/target-connection.c |  6 ++----
>  gdb/thread.c            |  6 +-----
>  gdb/ui-out.c            |  9 +++++++++
>  gdb/ui-out.h            | 13 +++++++++++++
>  8 files changed, 29 insertions(+), 27 deletions(-)

LGTM.

Approved-by: Kevin Buettner <kevinb@redhat.com>


  reply	other threads:[~2025-05-14  2:11 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-09 20:18 [PATCH 0/2] Use check-mark for current row of CLI table Tom Tromey
2025-05-09 20:18 ` [PATCH 1/2] Introduce ui_out::field_check_mark Tom Tromey
2025-05-14  2:10   ` Kevin Buettner [this message]
2025-05-09 20:18 ` [PATCH 2/2] Allow check-mark to be changed for CLI Tom Tromey
2025-05-10  6:23   ` Eli Zaretskii
2025-05-10  6:32   ` Eli Zaretskii
2025-05-16 14:18     ` Tom Tromey
2025-05-16 16:09       ` Eli Zaretskii
2025-05-23 15:00         ` Kévin Le Gouguec
2025-05-23 15:42           ` Eli Zaretskii
2025-06-11 13:53           ` Tom Tromey
2025-05-14 15:41   ` Andrew Burgess
2025-05-16 14:20     ` Tom Tromey
2025-05-16 16:16       ` Eli Zaretskii
2025-06-25 19:11         ` Pedro Alves
2025-06-26  5:51           ` Eli Zaretskii
2025-06-26 10:35             ` Pedro Alves
2025-06-26 12:32               ` Eli Zaretskii
2025-06-30 23:51                 ` Pedro Alves
2025-06-30 23:58                   ` Pedro Alves
2025-05-19 12:54       ` Andrew Burgess
2025-06-20 16:22   ` Pedro Alves
2025-06-24 16:58     ` Tom Tromey
2025-06-25 10:05       ` Pedro Alves
2025-06-25 15:43         ` Tom Tromey
2025-06-25 17:21           ` Pedro Alves
2025-06-27 16:17             ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250513191014.56a1b764@f42-zbm-amd \
    --to=kevinb@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@adacore.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox