Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Kévin Le Gouguec" <legouguec@adacore.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Tom Tromey <tromey@adacore.com>,  gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] Allow check-mark to be changed for CLI
Date: Fri, 23 May 2025 17:00:31 +0200	[thread overview]
Message-ID: <87ecwfz81c.fsf@adacore.com> (raw)
In-Reply-To: <86jz6gy1u0.fsf@gnu.org>

Eli Zaretskii <eliz@gnu.org> writes:

>> >> From: Tom Tromey <tromey@adacore.com>
>> >> Date: Fri, 09 May 2025 14:18:51 -0600
>> >> Cc: Tom Tromey <tromey@adacore.com>
>> >> 
>> >> +/* Emoji check-mark.  */
>> >> +static std::string check_mark = "✓";
>> 
>> Eli> Btw, if this is related to emoji display, shouldn't the default be
>> Eli> U+2713 followed by U+FE0F VARIATION SELECTOR-16, to show the "emoji
>> Eli> presentation" of the CHECK MARK character, if the terminal supports
>> Eli> that?  Or do too few terminals have such support?
>> 
>> I tried this but this combination doesn't seem to change the display.
>
> I think this might depend on the terminal.  E.g., the display in Emacs
> does change, at least here and with fonts I'm using for Emoji.

In this specific example, could it just be that U+2713 CHECK MARK has no
emoji presentation, or am I reading emoji-data.txt wrong?

From my emacs.git copy:

    # ================================================

    # All omitted code points have Emoji=No

    […]
    2705          ; Emoji                # E0.6   [1] (✅)       check mark button
    2708..270C    ; Emoji                # E0.6   [5] (✈️..✌️)    airplane..victory hand
    270D          ; Emoji                # E0.7   [1] (✍️)       writing hand
    270F          ; Emoji                # E0.6   [1] (✏️)       pencil
    2712          ; Emoji                # E0.6   [1] (✒️)       black nib
    2714          ; Emoji                # E0.6   [1] (✔️)       check mark
    […]

    # ================================================

    # All omitted code points have Emoji_Presentation=No

    […]
    2705          ; Emoji_Presentation   # E0.6   [1] (✅)       check mark button
    270A..270B    ; Emoji_Presentation   # E0.6   [2] (✊..✋)    raised fist..raised hand
    2728          ; Emoji_Presentation   # E0.6   [1] (✨)       sparkles

Notably absent: 2713?  So 2714 does vary with (✔️) & without (✔) VS-16,
but not 2713?

  reply	other threads:[~2025-05-23 15:01 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-09 20:18 [PATCH 0/2] Use check-mark for current row of CLI table Tom Tromey
2025-05-09 20:18 ` [PATCH 1/2] Introduce ui_out::field_check_mark Tom Tromey
2025-05-14  2:10   ` Kevin Buettner
2025-05-09 20:18 ` [PATCH 2/2] Allow check-mark to be changed for CLI Tom Tromey
2025-05-10  6:23   ` Eli Zaretskii
2025-05-10  6:32   ` Eli Zaretskii
2025-05-16 14:18     ` Tom Tromey
2025-05-16 16:09       ` Eli Zaretskii
2025-05-23 15:00         ` Kévin Le Gouguec [this message]
2025-05-23 15:42           ` Eli Zaretskii
2025-06-11 13:53           ` Tom Tromey
2025-05-14 15:41   ` Andrew Burgess
2025-05-16 14:20     ` Tom Tromey
2025-05-16 16:16       ` Eli Zaretskii
2025-06-25 19:11         ` Pedro Alves
2025-06-26  5:51           ` Eli Zaretskii
2025-06-26 10:35             ` Pedro Alves
2025-06-26 12:32               ` Eli Zaretskii
2025-06-30 23:51                 ` Pedro Alves
2025-06-30 23:58                   ` Pedro Alves
2025-05-19 12:54       ` Andrew Burgess
2025-06-20 16:22   ` Pedro Alves
2025-06-24 16:58     ` Tom Tromey
2025-06-25 10:05       ` Pedro Alves
2025-06-25 15:43         ` Tom Tromey
2025-06-25 17:21           ` Pedro Alves
2025-06-27 16:17             ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ecwfz81c.fsf@adacore.com \
    --to=legouguec@adacore.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@adacore.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox