Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@palves.net>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] Allow check-mark to be changed for CLI
Date: Wed, 25 Jun 2025 11:05:35 +0100	[thread overview]
Message-ID: <9621fa1e-76bb-42ca-bcb7-bb8f0560a89d@palves.net> (raw)
In-Reply-To: <87tt45xeik.fsf@tromey.com>

On 2025-06-24 17:58, Tom Tromey wrote:
> Pedro> To indicate the selected entry from a list, I think a right
> Pedro> arrow, or "👉" (Backhand Index Pointing Right, U+1F449) would
> Pedro> make a lot more sense.
> 
> I tried that one just now and at least on my terminal it is wider.
> See the attached screenshot.
> 
> Now, we could make "current" take 2 columns.  That might be enough to
> solve this in general.  But then a bit of space is wasted in the ASCII /
> narrow case.

Column widths don't have to be hardcoded.  For example, we compute the width of the "Target Id"
column dynamically.  See target_id_col_width in print_thread_info_1.  So maybe all we need is to
base the "current" column's width depend on the wcwidth of the character used.  Even if we end up
with a narrower character by default, the user can always configure their style to use a wider
one, so it seems to me like we should do that regardless.

I'm undecided myself between backhand and Right Arrow (➡️) or one of the latter's variants.  I like backhand
and I think its use is quite widespread for this.  OTOH, an arrow might look a bit more "professional".
Not sure, I've not really tried it any of this.

Pedro Alves

  reply	other threads:[~2025-06-25 10:06 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-09 20:18 [PATCH 0/2] Use check-mark for current row of CLI table Tom Tromey
2025-05-09 20:18 ` [PATCH 1/2] Introduce ui_out::field_check_mark Tom Tromey
2025-05-14  2:10   ` Kevin Buettner
2025-05-09 20:18 ` [PATCH 2/2] Allow check-mark to be changed for CLI Tom Tromey
2025-05-10  6:23   ` Eli Zaretskii
2025-05-10  6:32   ` Eli Zaretskii
2025-05-16 14:18     ` Tom Tromey
2025-05-16 16:09       ` Eli Zaretskii
2025-05-23 15:00         ` Kévin Le Gouguec
2025-05-23 15:42           ` Eli Zaretskii
2025-06-11 13:53           ` Tom Tromey
2025-05-14 15:41   ` Andrew Burgess
2025-05-16 14:20     ` Tom Tromey
2025-05-16 16:16       ` Eli Zaretskii
2025-06-25 19:11         ` Pedro Alves
2025-06-26  5:51           ` Eli Zaretskii
2025-06-26 10:35             ` Pedro Alves
2025-06-26 12:32               ` Eli Zaretskii
2025-06-30 23:51                 ` Pedro Alves
2025-06-30 23:58                   ` Pedro Alves
2025-05-19 12:54       ` Andrew Burgess
2025-06-20 16:22   ` Pedro Alves
2025-06-24 16:58     ` Tom Tromey
2025-06-25 10:05       ` Pedro Alves [this message]
2025-06-25 15:43         ` Tom Tromey
2025-06-25 17:21           ` Pedro Alves
2025-06-27 16:17             ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9621fa1e-76bb-42ca-bcb7-bb8f0560a89d@palves.net \
    --to=pedro@palves.net \
    --cc=gdb-patches@sourceware.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox