From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id wpTkIND7I2jcCSIAWB0awg (envelope-from ) for ; Tue, 13 May 2025 22:11:28 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=IgplUYcZ; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 73EA31E10E; Tue, 13 May 2025 22:11:28 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-10.1 required=5.0 tests=ARC_SIGNED,ARC_VALID, BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED, RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A25291E089 for ; Tue, 13 May 2025 22:11:27 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DA95E3856942 for ; Wed, 14 May 2025 02:11:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DA95E3856942 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=IgplUYcZ Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 4052C385735A for ; Wed, 14 May 2025 02:10:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4052C385735A Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4052C385735A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1747188625; cv=none; b=HCl/lzx6+zZMshI8PTIia485OfpWx7+IFyiGJZJAjP5iHYubSprQuVtyY4jd6Gcn1RjgPu/nZogAtCpVqwfyrDHebrGT4ZM+TPyH3JEpm1EaiXlNjX1fpmEmOPg+XIIgVViqUZiJC2qBFpIl+mGIg+VERFjgGcpyLlVRiN9mVwE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1747188625; c=relaxed/simple; bh=07ndvb3ITZYKSrMtFpoEvcloEc8r7y96aOTwHNyaktA=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=xd07U65qXpTy5MMNe56Z2/QQU1uCO2YHkx81OXB5AHLzl+TBKo+ea0+WOTNhU/pgV5jU/VVe6Yr+7hdqh5c9Cd2YZC/d1l9WRFVwApA2sWh4ZDcJNlh8BpB0i3HKhml6F29H98CZNozbwV69k8sOuPJtWLImc5JQjunB5hS159c= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4052C385735A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747188625; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9K4PrPM2YtKtChZjLgozE24KIamfZNkZvXdbbLD/X3Q=; b=IgplUYcZ7BT5NNC9szK9JDDDRbLmH3f0s0A0GtcVfEqIPC4gdkQ8YUv/z4DndisdWsFKrA W4vZCguF1sIazwP5NE+d26MIdVOCrwqN6QVbHo8oqhN6asU1l+nL3apDLhtewNz8CUiu5O Hhb0KThBHR4stTgmWwh6OimTVbZM5Is= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-180-bjmKk3TBOkubnkv6Jg6dDA-1; Tue, 13 May 2025 22:10:21 -0400 X-MC-Unique: bjmKk3TBOkubnkv6Jg6dDA-1 X-Mimecast-MFC-AGG-ID: bjmKk3TBOkubnkv6Jg6dDA_1747188621 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 928A1180045C; Wed, 14 May 2025 02:10:20 +0000 (UTC) Received: from f42-zbm-amd (unknown [10.22.80.66]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B560030002E3; Wed, 14 May 2025 02:10:19 +0000 (UTC) Date: Tue, 13 May 2025 19:10:14 -0700 From: Kevin Buettner To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: Re: [PATCH 1/2] Introduce ui_out::field_check_mark Message-ID: <20250513191014.56a1b764@f42-zbm-amd> In-Reply-To: <20250509-emoji-check-mark-v1-1-63b6c52411f3@adacore.com> References: <20250509-emoji-check-mark-v1-0-63b6c52411f3@adacore.com> <20250509-emoji-check-mark-v1-1-63b6c52411f3@adacore.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: tDnP6R5rW3v5uspDLcznSmd28_Jb1icJO7oOvs_xroo_1747188621 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Fri, 09 May 2025 14:18:50 -0600 Tom Tromey wrote: > This adds a new ui_out method, field_check_mark. This method is to be > used to indicate the "current" or "selected" row in a table. This > patch updates all the relevant tables to call this method. No change > should be expected. > --- > gdb/ada-tasks.c | 5 +---- > gdb/inferior.c | 6 +----- > gdb/linux-fork.c | 5 +---- > gdb/progspace.c | 6 +----- > gdb/target-connection.c | 6 ++---- > gdb/thread.c | 6 +----- > gdb/ui-out.c | 9 +++++++++ > gdb/ui-out.h | 13 +++++++++++++ > 8 files changed, 29 insertions(+), 27 deletions(-) LGTM. Approved-by: Kevin Buettner