Re: [PATCH 2/2] Allow check-mark to be changed for CLI

Tom Tromey
2025-05-16T14:20:39Z

>>>>> "Andrew" == Andrew Burgess <aburgess@redhat.com> writes:

Andrew> Tom Tromey <tromey@adacore.com> writes:
>> In keeping with the emojification of gdb, this patch changes the
>> default "current" marker to be a check-mark. It adds a knob to allow
>> the character to be changed, and, as always, reverts to the old output
>> when emojis are disabled.

Andrew> I haven't tested this patch just yet (short of time), but I wonder if I
Andrew> set the check-mark character to a multi-character string, does that
Andrew> corrupt the output? I'm guessing so as I don't think table columns
Andrew> auto-adjust.

Andrew> So my real question: at a minimum, should the docs mention that the
Andrew> STRING should only be a single character. And better yet, can we check
Andrew> that the string is only a single character in width somewhere?

Yeah, I will update the docs in v2.

I don't think there's any way to figure out what the display width of a
string might be. At least, not unless gdb adds a dependency on
something like libicu.

Tom