* [PATCH] gdb/aarch64-linux-tdep.c: Call linux_init_abi.
@ 2013-10-04 19:27 Will Newton
2013-10-07 5:02 ` Joel Brobecker
0 siblings, 1 reply; 4+ messages in thread
From: Will Newton @ 2013-10-04 19:27 UTC (permalink / raw)
To: gdb-patches; +Cc: patches
If we are running on a Linux platform we should call linux_init_abi
in order to get all the useful hooks it enables.
gdb/ChangeLog:
2013-10-04 Will Newton <will.newton@linaro.org>
* aarch64-linux-tdep.c (aarch64_linux_init_abi): Call
linux_init_abi.
---
gdb/aarch64-linux-tdep.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/gdb/aarch64-linux-tdep.c b/gdb/aarch64-linux-tdep.c
index 8e66425..bcfcce2 100644
--- a/gdb/aarch64-linux-tdep.c
+++ b/gdb/aarch64-linux-tdep.c
@@ -270,6 +270,8 @@ aarch64_linux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
tdep->lowest_pc = 0x8000;
+ linux_init_abi (info, gdbarch);
+
set_solib_svr4_fetch_link_map_offsets (gdbarch,
svr4_lp64_fetch_link_map_offsets);
--
1.8.1.4
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] gdb/aarch64-linux-tdep.c: Call linux_init_abi.
2013-10-04 19:27 [PATCH] gdb/aarch64-linux-tdep.c: Call linux_init_abi Will Newton
@ 2013-10-07 5:02 ` Joel Brobecker
2013-10-07 7:36 ` Will Newton
0 siblings, 1 reply; 4+ messages in thread
From: Joel Brobecker @ 2013-10-07 5:02 UTC (permalink / raw)
To: Will Newton; +Cc: gdb-patches, patches
> If we are running on a Linux platform we should call linux_init_abi
> in order to get all the useful hooks it enables.
>
> gdb/ChangeLog:
>
> 2013-10-04 Will Newton <will.newton@linaro.org>
>
> * aarch64-linux-tdep.c (aarch64_linux_init_abi): Call
> linux_init_abi.
This makes sense to me, and it's actually what the 32bit side of
the code is already doing. OK to apply.
It'd be nice also if you could confirm that this patch was tested
prior to submitting, and how it affects the testsuite results.
This often helps future research...
--
Joel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] gdb/aarch64-linux-tdep.c: Call linux_init_abi.
2013-10-07 5:02 ` Joel Brobecker
@ 2013-10-07 7:36 ` Will Newton
2013-10-10 10:41 ` Will Newton
0 siblings, 1 reply; 4+ messages in thread
From: Will Newton @ 2013-10-07 7:36 UTC (permalink / raw)
To: Joel Brobecker; +Cc: gdb-patches, Patch Tracking
On 7 October 2013 06:02, Joel Brobecker <brobecker@adacore.com> wrote:
>> If we are running on a Linux platform we should call linux_init_abi
>> in order to get all the useful hooks it enables.
>>
>> gdb/ChangeLog:
>>
>> 2013-10-04 Will Newton <will.newton@linaro.org>
>>
>> * aarch64-linux-tdep.c (aarch64_linux_init_abi): Call
>> linux_init_abi.
>
> This makes sense to me, and it's actually what the 32bit side of
> the code is already doing. OK to apply.
I'll wait a couple of days to see if anyone from ARM objects.
> It'd be nice also if you could confirm that this patch was tested
> prior to submitting, and how it affects the testsuite results.
> This often helps future research...
The patch was tested manually to check that things like "info proc
maps" now works. The testsuite is in pretty bad shape on aarch64 but
no new failures are added.
--
Will Newton
Toolchain Working Group, Linaro
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] gdb/aarch64-linux-tdep.c: Call linux_init_abi.
2013-10-07 7:36 ` Will Newton
@ 2013-10-10 10:41 ` Will Newton
0 siblings, 0 replies; 4+ messages in thread
From: Will Newton @ 2013-10-10 10:41 UTC (permalink / raw)
To: Joel Brobecker; +Cc: gdb-patches, Patch Tracking
On 7 October 2013 08:36, Will Newton <will.newton@linaro.org> wrote:
> On 7 October 2013 06:02, Joel Brobecker <brobecker@adacore.com> wrote:
>>> If we are running on a Linux platform we should call linux_init_abi
>>> in order to get all the useful hooks it enables.
>>>
>>> gdb/ChangeLog:
>>>
>>> 2013-10-04 Will Newton <will.newton@linaro.org>
>>>
>>> * aarch64-linux-tdep.c (aarch64_linux_init_abi): Call
>>> linux_init_abi.
>>
>> This makes sense to me, and it's actually what the 32bit side of
>> the code is already doing. OK to apply.
>
> I'll wait a couple of days to see if anyone from ARM objects.
>
>> It'd be nice also if you could confirm that this patch was tested
>> prior to submitting, and how it affects the testsuite results.
>> This often helps future research...
>
> The patch was tested manually to check that things like "info proc
> maps" now works. The testsuite is in pretty bad shape on aarch64 but
> no new failures are added.
I applied this as there were no objections.
--
Will Newton
Toolchain Working Group, Linaro
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-10-10 10:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-10-04 19:27 [PATCH] gdb/aarch64-linux-tdep.c: Call linux_init_abi Will Newton
2013-10-07 5:02 ` Joel Brobecker
2013-10-07 7:36 ` Will Newton
2013-10-10 10:41 ` Will Newton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox