From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17276 invoked by alias); 7 Oct 2013 05:02:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17261 invoked by uid 89); 7 Oct 2013 05:02:40 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 07 Oct 2013 05:02:40 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 4E33D1164D2; Mon, 7 Oct 2013 01:02:58 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id lzn+tbPy9IsE; Mon, 7 Oct 2013 01:02:58 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id DE4F91164CF; Mon, 7 Oct 2013 01:02:57 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 58DC2E1028; Mon, 7 Oct 2013 09:02:33 +0400 (RET) Date: Mon, 07 Oct 2013 05:02:00 -0000 From: Joel Brobecker To: Will Newton Cc: gdb-patches@sourceware.org, patches@linaro.org Subject: Re: [PATCH] gdb/aarch64-linux-tdep.c: Call linux_init_abi. Message-ID: <20131007050233.GB3092@adacore.com> References: <524F1684.8070804@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <524F1684.8070804@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2013-10/txt/msg00173.txt.bz2 > If we are running on a Linux platform we should call linux_init_abi > in order to get all the useful hooks it enables. > > gdb/ChangeLog: > > 2013-10-04 Will Newton > > * aarch64-linux-tdep.c (aarch64_linux_init_abi): Call > linux_init_abi. This makes sense to me, and it's actually what the 32bit side of the code is already doing. OK to apply. It'd be nice also if you could confirm that this patch was tested prior to submitting, and how it affects the testsuite results. This often helps future research... -- Joel