From: Will Newton <will.newton@linaro.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
Patch Tracking <patches@linaro.org>
Subject: Re: [PATCH] gdb/aarch64-linux-tdep.c: Call linux_init_abi.
Date: Mon, 07 Oct 2013 07:36:00 -0000 [thread overview]
Message-ID: <CANu=Dmj3vKXVTACXiouf1qzF9MosT8GbNfAhakUnoAXuq-H2EQ@mail.gmail.com> (raw)
In-Reply-To: <20131007050233.GB3092@adacore.com>
On 7 October 2013 06:02, Joel Brobecker <brobecker@adacore.com> wrote:
>> If we are running on a Linux platform we should call linux_init_abi
>> in order to get all the useful hooks it enables.
>>
>> gdb/ChangeLog:
>>
>> 2013-10-04 Will Newton <will.newton@linaro.org>
>>
>> * aarch64-linux-tdep.c (aarch64_linux_init_abi): Call
>> linux_init_abi.
>
> This makes sense to me, and it's actually what the 32bit side of
> the code is already doing. OK to apply.
I'll wait a couple of days to see if anyone from ARM objects.
> It'd be nice also if you could confirm that this patch was tested
> prior to submitting, and how it affects the testsuite results.
> This often helps future research...
The patch was tested manually to check that things like "info proc
maps" now works. The testsuite is in pretty bad shape on aarch64 but
no new failures are added.
--
Will Newton
Toolchain Working Group, Linaro
next prev parent reply other threads:[~2013-10-07 7:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-04 19:27 Will Newton
2013-10-07 5:02 ` Joel Brobecker
2013-10-07 7:36 ` Will Newton [this message]
2013-10-10 10:41 ` Will Newton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANu=Dmj3vKXVTACXiouf1qzF9MosT8GbNfAhakUnoAXuq-H2EQ@mail.gmail.com' \
--to=will.newton@linaro.org \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=patches@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox