From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7152 invoked by alias); 7 Oct 2013 07:36:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7140 invoked by uid 89); 7 Oct 2013 07:36:43 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ie0-f182.google.com Received: from mail-ie0-f182.google.com (HELO mail-ie0-f182.google.com) (209.85.223.182) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 07 Oct 2013 07:36:42 +0000 Received: by mail-ie0-f182.google.com with SMTP id aq17so15075396iec.13 for ; Mon, 07 Oct 2013 00:36:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=6OeJZExzPD++DpAxA4fisKR+Kq/Wv5m3mzLVoWmlBaE=; b=MS4svFcSXCKADh45w7ZqFpq11+Xi5tEcPk2TP36ik35x7uxDcMud/Q87gIiUOEdnSz 4GU+xbK4lJkxJYEy5lhc2DemL4mxpOnXw+LmtDtT1HfLxMvjvErbXB4LZjzeOYqNhMS8 /SCA0VrGqrOST39dhFqf8AOInbceaGDaONXsS1bYwbDMmNqWfMbud8rUPxIP9CwqZAeo GFTognfGcR1rWvMzlxkmOxlx1WlR7s6SqAELOktYZk4Swex0cAPv57e0OX5uabdapChW Jmjs/UQMjHxExt0VeF5Zi3g7B7Le9cBaHkz1ce5skwpdCIfimUfe8bRjqi3V5VEW3wfK +B9g== X-Gm-Message-State: ALoCoQlimQCYsYRi9NvFEyEboQqGm1L/ITbguYiMCfxgSaoWMrYZoaZ58ajh503vY5rs6tRuaiig MIME-Version: 1.0 X-Received: by 10.50.20.99 with SMTP id m3mr15703836ige.54.1381131400763; Mon, 07 Oct 2013 00:36:40 -0700 (PDT) Received: by 10.64.20.52 with HTTP; Mon, 7 Oct 2013 00:36:40 -0700 (PDT) In-Reply-To: <20131007050233.GB3092@adacore.com> References: <524F1684.8070804@linaro.org> <20131007050233.GB3092@adacore.com> Date: Mon, 07 Oct 2013 07:36:00 -0000 Message-ID: Subject: Re: [PATCH] gdb/aarch64-linux-tdep.c: Call linux_init_abi. From: Will Newton To: Joel Brobecker Cc: "gdb-patches@sourceware.org" , Patch Tracking Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes X-SW-Source: 2013-10/txt/msg00175.txt.bz2 On 7 October 2013 06:02, Joel Brobecker wrote: >> If we are running on a Linux platform we should call linux_init_abi >> in order to get all the useful hooks it enables. >> >> gdb/ChangeLog: >> >> 2013-10-04 Will Newton >> >> * aarch64-linux-tdep.c (aarch64_linux_init_abi): Call >> linux_init_abi. > > This makes sense to me, and it's actually what the 32bit side of > the code is already doing. OK to apply. I'll wait a couple of days to see if anyone from ARM objects. > It'd be nice also if you could confirm that this patch was tested > prior to submitting, and how it affects the testsuite results. > This often helps future research... The patch was tested manually to check that things like "info proc maps" now works. The testsuite is in pretty bad shape on aarch64 but no new failures are added. -- Will Newton Toolchain Working Group, Linaro