From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30026 invoked by alias); 10 Oct 2013 10:41:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30017 invoked by uid 89); 10 Oct 2013 10:41:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ie0-f178.google.com Received: from mail-ie0-f178.google.com (HELO mail-ie0-f178.google.com) (209.85.223.178) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 10 Oct 2013 10:41:46 +0000 Received: by mail-ie0-f178.google.com with SMTP id to1so4490128ieb.23 for ; Thu, 10 Oct 2013 03:41:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=/IWJvAat+JmYZzs704W+7Pij5XbKgK4vh1pl9aaqG0g=; b=OB9162rnLAP29m//Mb/MHjtKeoOqHonf/RG7rCehl8J7E8HQtjglKx573F7JY1qqvO ixXcgzba37AjaQIo5y7cWgh/QjVy2ZWnKXJAbKGfjr2dxvWvyGK1x/x+qd5ToJ3sqdcp tbgmJtbjZAhxk2g2rS8oges8CrrKEa0Q6IXjatqaa36Hr0NNDTBB8QBbJdJ/XafHIRXl +WCj10ooxGJXEE7Sv0j8ZV+sYKxpBgl2Ej2gGscjUuKQ9rDdRUHci4uUvlnWWKkhFJxr PCO/ifd+FikcP0wpq0RtDRVmDVmOweeqaLNMaBzbl1jsPIIfWz8aX85qwh8WmArQAQaV gFPQ== X-Gm-Message-State: ALoCoQkZEA+G5pbxvSLQn4m/R+6edpjgi7rYqFIJZs3bynYSxB6KNQcRRXgq9XclhbArGOpdvFkh MIME-Version: 1.0 X-Received: by 10.50.127.197 with SMTP id ni5mr5815786igb.54.1381401704494; Thu, 10 Oct 2013 03:41:44 -0700 (PDT) Received: by 10.64.20.52 with HTTP; Thu, 10 Oct 2013 03:41:44 -0700 (PDT) In-Reply-To: References: <524F1684.8070804@linaro.org> <20131007050233.GB3092@adacore.com> Date: Thu, 10 Oct 2013 10:41:00 -0000 Message-ID: Subject: Re: [PATCH] gdb/aarch64-linux-tdep.c: Call linux_init_abi. From: Will Newton To: Joel Brobecker Cc: "gdb-patches@sourceware.org" , Patch Tracking Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes X-SW-Source: 2013-10/txt/msg00338.txt.bz2 On 7 October 2013 08:36, Will Newton wrote: > On 7 October 2013 06:02, Joel Brobecker wrote: >>> If we are running on a Linux platform we should call linux_init_abi >>> in order to get all the useful hooks it enables. >>> >>> gdb/ChangeLog: >>> >>> 2013-10-04 Will Newton >>> >>> * aarch64-linux-tdep.c (aarch64_linux_init_abi): Call >>> linux_init_abi. >> >> This makes sense to me, and it's actually what the 32bit side of >> the code is already doing. OK to apply. > > I'll wait a couple of days to see if anyone from ARM objects. > >> It'd be nice also if you could confirm that this patch was tested >> prior to submitting, and how it affects the testsuite results. >> This often helps future research... > > The patch was tested manually to check that things like "info proc > maps" now works. The testsuite is in pretty bad shape on aarch64 but > no new failures are added. I applied this as there were no objections. -- Will Newton Toolchain Working Group, Linaro