[COMMIT PATCH] Make "set/show debug coff_pe_read" a zuinteger instead of uinteger.

[COMMIT PATCH] Make "set/show debug coff_pe_read" a zuinteger instead of uinteger.

[Pedro Alves]

Being a uinteger means you can't disable debug output after enabling it...

  (gdb) show debug coff_pe_read
  Coff PE read debugging is 0.
  (gdb) set debug coff_pe_read 0
  (gdb) show debug coff_pe_read
  Coff PE read debugging is unlimited.
  (gdb)

gdb/
2013-03-26  Pedro Alves  <palves@redhat.com>

	* coff-pe-read.c (_initialize_coff_pe_read): Make the command
	zuinteger instead of uinteger.
---
 gdb/coff-pe-read.c |   16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/gdb/coff-pe-read.c b/gdb/coff-pe-read.c
index c930bac..01e9b51 100644
--- a/gdb/coff-pe-read.c
+++ b/gdb/coff-pe-read.c
@@ -707,12 +707,12 @@ void _initialize_coff_pe_read (void);
 void
 _initialize_coff_pe_read (void)
 {
-  add_setshow_uinteger_cmd ("coff_pe_read", class_maintenance,
-			    &debug_coff_pe_read,
-			    _("Set coff PE read debugging."),
-			    _("Show coff PE read debugging."),
-			    _("When set, debugging messages for coff reading "
-			      "of exported symbols are displayed."),
-			    NULL, show_debug_coff_pe_read,
-			    &setdebuglist, &showdebuglist);
+  add_setshow_zuinteger_cmd ("coff_pe_read", class_maintenance,
+			     &debug_coff_pe_read,
+			     _("Set coff PE read debugging."),
+			     _("Show coff PE read debugging."),
+			     _("When set, debugging messages for coff reading "
+			       "of exported symbols are displayed."),
+			     NULL, show_debug_coff_pe_read,
+			     &setdebuglist, &showdebuglist);
 }

Re: [COMMIT PATCH] Make "set/show debug coff_pe_read" a zuinteger instead of uinteger.

[Pedro Alves]

On 03/26/2013 06:41 PM, Pedro Alves wrote:
>   (gdb) set debug coff_pe_read 0

BTW, "coff_pe_read" instead of "coff-pe-read" looked like a typo to me.

-- 
Pedro Alves

RE: [COMMIT PATCH] Make "set/show debug coff_pe_read" a zuinteger instead of uinteger.

[Pierre Muller]

  Sorry about this mistake, 
(I added this set/show command when I 
fixed some problems with the coff pe reader).

I didn't really know the difference between the two...
  Concerning the name of the variable,
you are right that using hyphens instead of
underscores seems to be the "unwritten?" rule.
  I have no objection to switching to coff-pe-read.

Pierre Muller

> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Pedro Alves
> Envoyé : mardi 26 mars 2013 19:41
> À : gdb-patches@sourceware.org
> Objet : [COMMIT PATCH] Make "set/show debug coff_pe_read" a zuinteger
> instead of uinteger.
> 
> Being a uinteger means you can't disable debug output after enabling it...
> 
>   (gdb) show debug coff_pe_read
>   Coff PE read debugging is 0.
>   (gdb) set debug coff_pe_read 0
>   (gdb) show debug coff_pe_read
>   Coff PE read debugging is unlimited.
>   (gdb)
> 
> gdb/
> 2013-03-26  Pedro Alves  <palves@redhat.com>
> 
> 	* coff-pe-read.c (_initialize_coff_pe_read): Make the command
> 	zuinteger instead of uinteger.
> ---
>  gdb/coff-pe-read.c |   16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/gdb/coff-pe-read.c b/gdb/coff-pe-read.c
> index c930bac..01e9b51 100644
> --- a/gdb/coff-pe-read.c
> +++ b/gdb/coff-pe-read.c
> @@ -707,12 +707,12 @@ void _initialize_coff_pe_read (void);
>  void
>  _initialize_coff_pe_read (void)
>  {
> -  add_setshow_uinteger_cmd ("coff_pe_read", class_maintenance,
> -			    &debug_coff_pe_read,
> -			    _("Set coff PE read debugging."),
> -			    _("Show coff PE read debugging."),
> -			    _("When set, debugging messages for coff reading "
> -			      "of exported symbols are displayed."),
> -			    NULL, show_debug_coff_pe_read,
> -			    &setdebuglist, &showdebuglist);
> +  add_setshow_zuinteger_cmd ("coff_pe_read", class_maintenance,
> +			     &debug_coff_pe_read,
> +			     _("Set coff PE read debugging."),
> +			     _("Show coff PE read debugging."),
> +			     _("When set, debugging messages for coff reading "
> +			       "of exported symbols are displayed."),
> +			     NULL, show_debug_coff_pe_read,
> +			     &setdebuglist, &showdebuglist);
>  }

[COMMIT mainline+7.6 PATCH] Rename "set debug coff_pe_read" command to "set debug coff-pe-read". (was: Re: [COMMIT PATCH] Make "set/show debug coff_pe_read" a zuinteger instead of uinteger.)

[Pedro Alves]

On 03/26/2013 09:58 PM, Pierre Muller wrote:
>   Sorry about this mistake, 
> (I added this set/show command when I 
> fixed some problems with the coff pe reader).

No problem.  I blame it on the non-intuitive ado_foo function
names.

> I didn't really know the difference between the two...
>   Concerning the name of the variable,
> you are right that using hyphens instead of
> underscores seems to be the "unwritten?" rule.
>   I have no objection to switching to coff-pe-read.

Done.

(I grepped the manual to check whether it'd need to be changed there too.)

------------
Subject: Rename "set debug coff_pe_read" command to "set debug coff-pe-read".

Hyphens are much more common than underscores in command names.

gdb/
2013-03-27  Pedro Alves  <palves@redhat.com>

	* coff-pe-read.c (_initialize_coff_pe_read): Rename "set debug
	coff_pe_read" command to "set debug coff-pe-read".
---

 gdb/coff-pe-read.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/coff-pe-read.c b/gdb/coff-pe-read.c
index 01e9b51..4be349d 100644
--- a/gdb/coff-pe-read.c
+++ b/gdb/coff-pe-read.c
@@ -707,7 +707,7 @@ void _initialize_coff_pe_read (void);
 void
 _initialize_coff_pe_read (void)
 {
-  add_setshow_zuinteger_cmd ("coff_pe_read", class_maintenance,
+  add_setshow_zuinteger_cmd ("coff-pe-read", class_maintenance,
 			     &debug_coff_pe_read,
 			     _("Set coff PE read debugging."),
 			     _("Show coff PE read debugging."),

Re: [COMMIT PATCH] Make "set/show debug coff_pe_read" a zuinteger instead of uinteger.

[Pedro Alves]

On 03/26/2013 06:41 PM, Pedro Alves wrote:
> Being a uinteger means you can't disable debug output after enabling it...
> 
>   (gdb) show debug coff_pe_read
>   Coff PE read debugging is 0.
>   (gdb) set debug coff_pe_read 0
>   (gdb) show debug coff_pe_read
>   Coff PE read debugging is unlimited.
>   (gdb)
> 
> gdb/
> 2013-03-26  Pedro Alves  <palves@redhat.com>
> 
> 	* coff-pe-read.c (_initialize_coff_pe_read): Make the command
> 	zuinteger instead of uinteger.

I've put this in 7.6 as well.

-- 
Pedro Alves