From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20570 invoked by alias); 26 Mar 2013 21:58:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20550 invoked by uid 89); 26 Mar 2013 21:58:29 -0000 X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,MSGID_MULTIPLE_AT autolearn=no version=3.3.1 Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.201.46) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 26 Mar 2013 21:58:27 +0000 Received: from md16.u-strasbg.fr (md16.u-strasbg.fr [130.79.200.206]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id r2QLwJqK022633 ; Tue, 26 Mar 2013 22:58:19 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms16.u-strasbg.fr [130.79.204.116]) by md16.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id r2QLwJCI022135 ; Tue, 26 Mar 2013 22:58:19 +0100 (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from E6510Muller (lec67-4-82-230-53-140.fbx.proxad.net [82.230.53.140]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id r2QLwHPG028469 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO) ; Tue, 26 Mar 2013 22:58:18 +0100 (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: "'Pedro Alves'" , References: <20130326184101.29735.59747.stgit@brno.lan> In-Reply-To: <20130326184101.29735.59747.stgit@brno.lan> Subject: RE: [COMMIT PATCH] Make "set/show debug coff_pe_read" a zuinteger instead of uinteger. Date: Wed, 27 Mar 2013 05:29:00 -0000 Message-ID: <000401ce2a6d$059229f0$10b67dd0$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-SW-Source: 2013-03/txt/msg00995.txt.bz2 Sorry about this mistake,=20 (I added this set/show command when I=20 fixed some problems with the coff pe reader). I didn't really know the difference between the two... Concerning the name of the variable, you are right that using hyphens instead of underscores seems to be the "unwritten?" rule. I have no objection to switching to coff-pe-read. Pierre Muller > -----Message d'origine----- > De : gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Pedro Alves > Envoy=C3=A9 : mardi 26 mars 2013 19:41 > =C3=80 : gdb-patches@sourceware.org > Objet : [COMMIT PATCH] Make "set/show debug coff_pe_read" a zuinteger > instead of uinteger. >=20 > Being a uinteger means you can't disable debug output after enabling it... >=20 > (gdb) show debug coff_pe_read > Coff PE read debugging is 0. > (gdb) set debug coff_pe_read 0 > (gdb) show debug coff_pe_read > Coff PE read debugging is unlimited. > (gdb) >=20 > gdb/ > 2013-03-26 Pedro Alves >=20 > * coff-pe-read.c (_initialize_coff_pe_read): Make the command > zuinteger instead of uinteger. > --- > gdb/coff-pe-read.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) >=20 > diff --git a/gdb/coff-pe-read.c b/gdb/coff-pe-read.c > index c930bac..01e9b51 100644 > --- a/gdb/coff-pe-read.c > +++ b/gdb/coff-pe-read.c > @@ -707,12 +707,12 @@ void _initialize_coff_pe_read (void); > void > _initialize_coff_pe_read (void) > { > - add_setshow_uinteger_cmd ("coff_pe_read", class_maintenance, > - &debug_coff_pe_read, > - _("Set coff PE read debugging."), > - _("Show coff PE read debugging."), > - _("When set, debugging messages for coff reading " > - "of exported symbols are displayed."), > - NULL, show_debug_coff_pe_read, > - &setdebuglist, &showdebuglist); > + add_setshow_zuinteger_cmd ("coff_pe_read", class_maintenance, > + &debug_coff_pe_read, > + _("Set coff PE read debugging."), > + _("Show coff PE read debugging."), > + _("When set, debugging messages for coff reading " > + "of exported symbols are displayed."), > + NULL, show_debug_coff_pe_read, > + &setdebuglist, &showdebuglist); > }