Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: gdb-patches@sourceware.org
Subject: [COMMIT PATCH] Make "set/show debug coff_pe_read" a zuinteger instead of uinteger.
Date: Tue, 26 Mar 2013 20:01:00 -0000	[thread overview]
Message-ID: <20130326184101.29735.59747.stgit@brno.lan> (raw)

Being a uinteger means you can't disable debug output after enabling it...

  (gdb) show debug coff_pe_read
  Coff PE read debugging is 0.
  (gdb) set debug coff_pe_read 0
  (gdb) show debug coff_pe_read
  Coff PE read debugging is unlimited.
  (gdb)

gdb/
2013-03-26  Pedro Alves  <palves@redhat.com>

	* coff-pe-read.c (_initialize_coff_pe_read): Make the command
	zuinteger instead of uinteger.
---
 gdb/coff-pe-read.c |   16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/gdb/coff-pe-read.c b/gdb/coff-pe-read.c
index c930bac..01e9b51 100644
--- a/gdb/coff-pe-read.c
+++ b/gdb/coff-pe-read.c
@@ -707,12 +707,12 @@ void _initialize_coff_pe_read (void);
 void
 _initialize_coff_pe_read (void)
 {
-  add_setshow_uinteger_cmd ("coff_pe_read", class_maintenance,
-			    &debug_coff_pe_read,
-			    _("Set coff PE read debugging."),
-			    _("Show coff PE read debugging."),
-			    _("When set, debugging messages for coff reading "
-			      "of exported symbols are displayed."),
-			    NULL, show_debug_coff_pe_read,
-			    &setdebuglist, &showdebuglist);
+  add_setshow_zuinteger_cmd ("coff_pe_read", class_maintenance,
+			     &debug_coff_pe_read,
+			     _("Set coff PE read debugging."),
+			     _("Show coff PE read debugging."),
+			     _("When set, debugging messages for coff reading "
+			       "of exported symbols are displayed."),
+			     NULL, show_debug_coff_pe_read,
+			     &setdebuglist, &showdebuglist);
 }


             reply	other threads:[~2013-03-26 18:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-26 20:01 Pedro Alves [this message]
2013-03-26 20:08 ` Pedro Alves
2013-03-27  5:29 ` Pierre Muller
     [not found] ` <51521a12.a5c9440a.2a55.5a18SMTPIN_ADDED_BROKEN@mx.google.com>
2013-03-27 11:28   ` [COMMIT mainline+7.6 PATCH] Rename "set debug coff_pe_read" command to "set debug coff-pe-read". (was: Re: [COMMIT PATCH] Make "set/show debug coff_pe_read" a zuinteger instead of uinteger.) Pedro Alves
2013-03-27 11:52 ` [COMMIT PATCH] Make "set/show debug coff_pe_read" a zuinteger instead of uinteger Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130326184101.29735.59747.stgit@brno.lan \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox