Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
Cc: gdb-patches@sourceware.org
Subject: [COMMIT mainline+7.6 PATCH] Rename "set debug coff_pe_read" command to "set debug coff-pe-read". (was: Re: [COMMIT PATCH] Make "set/show debug coff_pe_read" a zuinteger instead of uinteger.)
Date: Wed, 27 Mar 2013 11:28:00 -0000	[thread overview]
Message-ID: <5152C3AF.8020902@redhat.com> (raw)
In-Reply-To: <51521a12.a5c9440a.2a55.5a18SMTPIN_ADDED_BROKEN@mx.google.com>

On 03/26/2013 09:58 PM, Pierre Muller wrote:
>   Sorry about this mistake, 
> (I added this set/show command when I 
> fixed some problems with the coff pe reader).

No problem.  I blame it on the non-intuitive ado_foo function
names.

> I didn't really know the difference between the two...
>   Concerning the name of the variable,
> you are right that using hyphens instead of
> underscores seems to be the "unwritten?" rule.
>   I have no objection to switching to coff-pe-read.

Done.

(I grepped the manual to check whether it'd need to be changed there too.)

------------
Subject: Rename "set debug coff_pe_read" command to "set debug coff-pe-read".

Hyphens are much more common than underscores in command names.

gdb/
2013-03-27  Pedro Alves  <palves@redhat.com>

	* coff-pe-read.c (_initialize_coff_pe_read): Rename "set debug
	coff_pe_read" command to "set debug coff-pe-read".
---

 gdb/coff-pe-read.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/coff-pe-read.c b/gdb/coff-pe-read.c
index 01e9b51..4be349d 100644
--- a/gdb/coff-pe-read.c
+++ b/gdb/coff-pe-read.c
@@ -707,7 +707,7 @@ void _initialize_coff_pe_read (void);
 void
 _initialize_coff_pe_read (void)
 {
-  add_setshow_zuinteger_cmd ("coff_pe_read", class_maintenance,
+  add_setshow_zuinteger_cmd ("coff-pe-read", class_maintenance,
 			     &debug_coff_pe_read,
 			     _("Set coff PE read debugging."),
 			     _("Show coff PE read debugging."),


  parent reply	other threads:[~2013-03-27 10:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-26 20:01 [COMMIT PATCH] Make "set/show debug coff_pe_read" a zuinteger instead of uinteger Pedro Alves
2013-03-26 20:08 ` Pedro Alves
2013-03-27  5:29 ` Pierre Muller
     [not found] ` <51521a12.a5c9440a.2a55.5a18SMTPIN_ADDED_BROKEN@mx.google.com>
2013-03-27 11:28   ` Pedro Alves [this message]
2013-03-27 11:52 ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5152C3AF.8020902@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pierre.muller@ics-cnrs.unistra.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox