From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7828 invoked by alias); 27 Mar 2013 10:02:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7531 invoked by uid 89); 27 Mar 2013 10:02:32 -0000 X-Spam-SWARE-Status: No, score=-8.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 27 Mar 2013 10:02:29 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2RA2Pon002798 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 27 Mar 2013 06:02:25 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r2RA2Ng9031988; Wed, 27 Mar 2013 06:02:24 -0400 Message-ID: <5152C3AF.8020902@redhat.com> Date: Wed, 27 Mar 2013 11:28:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 MIME-Version: 1.0 To: Pierre Muller CC: gdb-patches@sourceware.org Subject: [COMMIT mainline+7.6 PATCH] Rename "set debug coff_pe_read" command to "set debug coff-pe-read". (was: Re: [COMMIT PATCH] Make "set/show debug coff_pe_read" a zuinteger instead of uinteger.) References: <20130326184101.29735.59747.stgit@brno.lan> <51521a12.a5c9440a.2a55.5a18SMTPIN_ADDED_BROKEN@mx.google.com> In-Reply-To: <51521a12.a5c9440a.2a55.5a18SMTPIN_ADDED_BROKEN@mx.google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-03/txt/msg01010.txt.bz2 On 03/26/2013 09:58 PM, Pierre Muller wrote: > Sorry about this mistake, > (I added this set/show command when I > fixed some problems with the coff pe reader). No problem. I blame it on the non-intuitive ado_foo function names. > I didn't really know the difference between the two... > Concerning the name of the variable, > you are right that using hyphens instead of > underscores seems to be the "unwritten?" rule. > I have no objection to switching to coff-pe-read. Done. (I grepped the manual to check whether it'd need to be changed there too.) ------------ Subject: Rename "set debug coff_pe_read" command to "set debug coff-pe-read". Hyphens are much more common than underscores in command names. gdb/ 2013-03-27 Pedro Alves * coff-pe-read.c (_initialize_coff_pe_read): Rename "set debug coff_pe_read" command to "set debug coff-pe-read". --- gdb/coff-pe-read.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/coff-pe-read.c b/gdb/coff-pe-read.c index 01e9b51..4be349d 100644 --- a/gdb/coff-pe-read.c +++ b/gdb/coff-pe-read.c @@ -707,7 +707,7 @@ void _initialize_coff_pe_read (void); void _initialize_coff_pe_read (void) { - add_setshow_zuinteger_cmd ("coff_pe_read", class_maintenance, + add_setshow_zuinteger_cmd ("coff-pe-read", class_maintenance, &debug_coff_pe_read, _("Set coff PE read debugging."), _("Show coff PE read debugging."),