Re: [PATCH 2/2] Remove pass in skip_unwinder_tests

[Jan Kratochvil <jan.kratochvil@redhat.com>]

On Thu, 23 Aug 2012 11:49:49 +0200, Yao Qi wrote:
> As we discussed, proc skip_unwinder_tests should not generate any FAIL
> or PASS in test summary,

During comparison across releases and testsuite modes it makes the diffs more
difficult to read:

 Running gdb/testsuite/gdb.java/jnpe.exp ...
 PASS: gdb.java/jnpe.exp: compilation jnpe.java
-FAIL: gdb.java/jnpe.exp: check for unwinder hook
 PASS: gdb.java/jnpe.exp: disable SIGSEGV for next-over-NPE
 PASS: gdb.java/jnpe.exp: next over NPE
-PASS: gdb.java/jnpe.exp: continue to success for next-over-NPE
+FAIL: gdb.java/jnpe.exp: continue to success for next-over-NPE


Has the last testcase regressed because the check "check for unwinder hook" is
therefore no longer there?  Does it PASS or FAIL now? etc.


In other case:

#gdb.java/jnpe.exp
 Running gdb/testsuite/gdb.java/jnpe.exp ...
 PASS: gdb.java/jnpe.exp: compilation jnpe.java
-PASS: gdb.java/jnpe.exp: check for unwinder hook
 PASS: gdb.java/jnpe.exp: disable SIGSEGV for next-over-NPE
 PASS: gdb.java/jnpe.exp: next over NPE
 FAIL: gdb.java/jnpe.exp: continue to success for next-over-NPE

It was clear before why the testcase failed - because its
'check for unwinder hook' PASSes which should not in RHEL-5 x86_64 -m32 mode
(as debuginfo from gcc libraries is missing there).

the testcase was doing:

 (gdb) print _Unwind_DebugHook^M
 $1 = {void(void, void)} 0x7ffff78d4a90 <_Unwind_DebugHook>^M
 (gdb) PASS: gdb.java/jnpe.exp: check for unwinder hook
 handle SIGSEGV nostop noprint^M
 Signal        Stop     Print   Pass to program Description^M
 SIGSEGV       No       No      Yes             Segmentation fault^M
 (gdb) PASS: gdb.java/jnpe.exp: disable SIGSEGV for next-over-NPE

Not is that "print _Unwind_DebugHook"
 a part of the "disable SIGSEGV for next-over-NPE" test?

 (gdb) print _Unwind_DebugHook^M
 $1 = {void(void, void)} 0x7ffff78d4a90 <_Unwind_DebugHook>^M
 (gdb) handle SIGSEGV nostop noprint^M
 Signal        Stop     Print   Pass to program Description^M
 SIGSEGV       No       No      Yes             Segmentation fault^M
 (gdb) PASS: gdb.java/jnpe.exp: disable SIGSEGV for next-over-NPE

I do not see removing of useful messages to be much improvement.
I understand it was checked in with a good intention.


Jan