From: Yao Qi <yao@codesourcery.com>
To: <gdb-patches@sourceware.org>
Subject: [PATCH 2/2] Remove pass in skip_unwinder_tests
Date: Thu, 23 Aug 2012 09:50:00 -0000 [thread overview]
Message-ID: <1345715389-20955-2-git-send-email-yao@codesourcery.com> (raw)
In-Reply-To: <1345715389-20955-1-git-send-email-yao@codesourcery.com>
Hi,
As we discussed, proc skip_unwinder_tests should not generate any FAIL
or PASS in test summary, so this patch is a follow-up to to remove
'pass', and replace gdb_test_multiple with send_gdb/gdb_expect. With
this patch applied, these PASS are disappeared in test result.
-PASS: gdb.cp/nextoverthrow.exp: check for unwinder hook
-PASS: gdb.cp/nextoverthrow.exp: check for stap probe in unwinder
-PASS: gdb.java/jnpe.exp: check for unwinder hook
-PASS: gdb.java/jnpe.exp: check for stap probe in unwinder
gdb/testsuite:
2012-08-23 Yao Qi <yao@codesourcery.com>
* lib/gdb.exp (skip_unwinder_tests): Replace 'gdb_test_multiple'
with 'send_gdb' and 'gdb_expect'. Remove pass.
---
gdb/testsuite/lib/gdb.exp | 13 +++++--------
1 files changed, 5 insertions(+), 8 deletions(-)
diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index 0b02f76..99d6591 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -2102,25 +2102,22 @@ proc skip_unwinder_tests {} {
global gdb_prompt
set ok 1
- gdb_test_multiple "print _Unwind_DebugHook" "check for unwinder hook" {
+
+ send_gdb "print _Unwind_DebugHook\n"
+ gdb_expect {
-re "= .*no debug info.*_Unwind_DebugHook.*\r\n$gdb_prompt $" {
- # Pass the test so we don't get bogus fails in the results.
- pass "check for unwinder hook"
set ok 0
}
-re "= .*_Unwind_DebugHook.*\r\n$gdb_prompt $" {
- pass "check for unwinder hook"
}
-re "No symbol .* in current context.\r\n$gdb_prompt $" {
- # Pass the test so we don't get bogus fails in the results.
- pass "check for unwinder hook"
set ok 0
}
}
if {!$ok} {
- gdb_test_multiple "info probe" "check for stap probe in unwinder" {
+ send_gdb "info probe\n"
+ gdb_expect {
-re ".*libgcc.*unwind.*\r\n$gdb_prompt $" {
- pass "check for stap probe in unwinder"
set ok 1
}
-re "\r\n$gdb_prompt $" {
--
1.7.7.6
next prev parent reply other threads:[~2012-08-23 9:50 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-14 16:20 RFC: consolidate checks for _Unwind_DebugHook in test suite Tom Tromey
2012-08-15 0:53 ` Yao Qi
2012-08-15 13:58 ` Tom Tromey
2012-08-22 14:26 ` Tom Tromey
2012-08-23 9:50 ` [PATCH 1/2] Append "." in error message Yao Qi
2012-08-23 9:50 ` Yao Qi [this message]
2012-08-23 10:52 ` [PATCH 2/2] Remove pass in skip_unwinder_tests Pedro Alves
2012-08-23 12:29 ` Yao Qi
2012-08-23 18:03 ` Pedro Alves
2012-08-24 13:38 ` Jan Kratochvil
2012-08-24 15:41 ` Pedro Alves
2012-08-24 16:19 ` Jan Kratochvil
2012-08-24 16:53 ` Pedro Alves
2012-08-24 16:57 ` Pedro Alves
2012-08-24 17:12 ` Jan Kratochvil
2012-08-27 10:33 ` Yao Qi
2012-08-27 13:07 ` Jan Kratochvil
2012-08-27 15:15 ` Yao Qi
2012-08-27 15:57 ` Jan Kratochvil
2012-08-24 13:34 ` [PATCH 1/2] Append "." in error message Jan Kratochvil
2012-08-24 13:40 ` RFC: consolidate checks for _Unwind_DebugHook in test suite Jan Kratochvil
2012-08-24 13:54 ` Tom Tromey
2012-08-24 14:08 ` Jan Kratochvil
2012-08-24 15:26 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1345715389-20955-2-git-send-email-yao@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox