Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFC: consolidate checks for _Unwind_DebugHook in test suite
Date: Fri, 24 Aug 2012 13:54:00 -0000	[thread overview]
Message-ID: <87ehmwmm4j.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20120824133931.GC5219@host2.jankratochvil.net> (Jan Kratochvil's	message of "Fri, 24 Aug 2012 15:39:31 +0200")

>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:

Jan> If gdb_test_multiple FAILs it will leave "ok" as 1 which will run the whole
Jan> testfile.  Was it intentional?  Maybe it was although I would expect the
Jan> opposite.

Bug inherited from the status quo ante.

What do you think of this?
I'm testing it.

Tom

diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index 97e79af..0b4c679 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -2101,15 +2101,14 @@ proc skip_hw_watchpoint_access_tests {} {
 proc skip_unwinder_tests {} {
     global gdb_prompt
 
-    set ok 1
+    set ok 0
     gdb_test_multiple "print _Unwind_DebugHook" "check for unwinder hook" {
 	-re "= .*no debug info.*_Unwind_DebugHook.*\r\n$gdb_prompt $" {
-	    set ok 0
 	}
 	-re "= .*_Unwind_DebugHook.*\r\n$gdb_prompt $" {
+	    set ok 1
 	}
 	-re "No symbol .* in current context.\r\n$gdb_prompt $" {
-	    set ok 0
 	}
     }
     if {!$ok} {


  reply	other threads:[~2012-08-24 13:54 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-14 16:20 Tom Tromey
2012-08-15  0:53 ` Yao Qi
2012-08-15 13:58   ` Tom Tromey
2012-08-22 14:26 ` Tom Tromey
2012-08-23  9:50 ` [PATCH 1/2] Append "." in error message Yao Qi
2012-08-23  9:50   ` [PATCH 2/2] Remove pass in skip_unwinder_tests Yao Qi
2012-08-23 10:52     ` Pedro Alves
2012-08-23 12:29       ` Yao Qi
2012-08-23 18:03         ` Pedro Alves
2012-08-24 13:38     ` Jan Kratochvil
2012-08-24 15:41       ` Pedro Alves
2012-08-24 16:19         ` Jan Kratochvil
2012-08-24 16:53           ` Pedro Alves
2012-08-24 16:57             ` Pedro Alves
2012-08-24 17:12             ` Jan Kratochvil
2012-08-27 10:33           ` Yao Qi
2012-08-27 13:07             ` Jan Kratochvil
2012-08-27 15:15               ` Yao Qi
2012-08-27 15:57                 ` Jan Kratochvil
2012-08-24 13:34   ` [PATCH 1/2] Append "." in error message Jan Kratochvil
2012-08-24 13:40 ` RFC: consolidate checks for _Unwind_DebugHook in test suite Jan Kratochvil
2012-08-24 13:54   ` Tom Tromey [this message]
2012-08-24 14:08     ` Jan Kratochvil
2012-08-24 15:26       ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ehmwmm4j.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox