From: Pedro Alves <palves@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] Remove pass in skip_unwinder_tests
Date: Thu, 23 Aug 2012 10:52:00 -0000 [thread overview]
Message-ID: <50360B4B.70806@redhat.com> (raw)
In-Reply-To: <1345715389-20955-2-git-send-email-yao@codesourcery.com>
On 08/23/2012 10:49 AM, Yao Qi wrote:
> As we discussed, proc skip_unwinder_tests should not generate any FAIL
> or PASS in test summary, so this patch is a follow-up to to remove
> 'pass', and replace gdb_test_multiple with send_gdb/gdb_expect. With
> this patch applied, these PASS are disappeared in test result.
Do we really need to replace gdb_test_multiple with send_gdb/gdb_expect?
gdb_test_multiple will only issue fails in the internal errors cases.
I find it acceptable that see nothing most the time, and see a FAIL
when something goes really really wrong. More acceptable than the
timeouts we likely get with send_gdb/gdb_expect in the same really
really wrong cases, that is.
--
Pedro Alves
next prev parent reply other threads:[~2012-08-23 10:52 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-14 16:20 RFC: consolidate checks for _Unwind_DebugHook in test suite Tom Tromey
2012-08-15 0:53 ` Yao Qi
2012-08-15 13:58 ` Tom Tromey
2012-08-22 14:26 ` Tom Tromey
2012-08-23 9:50 ` [PATCH 1/2] Append "." in error message Yao Qi
2012-08-23 9:50 ` [PATCH 2/2] Remove pass in skip_unwinder_tests Yao Qi
2012-08-23 10:52 ` Pedro Alves [this message]
2012-08-23 12:29 ` Yao Qi
2012-08-23 18:03 ` Pedro Alves
2012-08-24 13:38 ` Jan Kratochvil
2012-08-24 15:41 ` Pedro Alves
2012-08-24 16:19 ` Jan Kratochvil
2012-08-24 16:53 ` Pedro Alves
2012-08-24 16:57 ` Pedro Alves
2012-08-24 17:12 ` Jan Kratochvil
2012-08-27 10:33 ` Yao Qi
2012-08-27 13:07 ` Jan Kratochvil
2012-08-27 15:15 ` Yao Qi
2012-08-27 15:57 ` Jan Kratochvil
2012-08-24 13:34 ` [PATCH 1/2] Append "." in error message Jan Kratochvil
2012-08-24 13:40 ` RFC: consolidate checks for _Unwind_DebugHook in test suite Jan Kratochvil
2012-08-24 13:54 ` Tom Tromey
2012-08-24 14:08 ` Jan Kratochvil
2012-08-24 15:26 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50360B4B.70806@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox