From: Tom Tromey <tromey@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: RFC: consolidate checks for _Unwind_DebugHook in test suite
Date: Wed, 15 Aug 2012 13:58:00 -0000 [thread overview]
Message-ID: <87boicxnog.fsf@fleche.redhat.com> (raw)
In-Reply-To: <502AF2C3.4090507@codesourcery.com> (Yao Qi's message of "Wed, 15 Aug 2012 08:52:19 +0800")
Yao> Do we really need to put "pass" here? skip_* proc in lib/gdb.exp is
Yao> to do some check and return a boolean value. We don't have to
Yao> generate any PASS or FAIL during checking. I'd like to remove them.
I would like that too, but you can't really use gdb_test_multiple
without these, because it may emit fails on its own.
I think that is a bad factoring -- there should be a way to interact
with gdb without muddying affecting the test count. But right now there
isn't.
I wouldn't mind if someone changed this, but this patch is just a
straightforward refactoring.
Tom
next prev parent reply other threads:[~2012-08-15 13:58 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-14 16:20 Tom Tromey
2012-08-15 0:53 ` Yao Qi
2012-08-15 13:58 ` Tom Tromey [this message]
2012-08-22 14:26 ` Tom Tromey
2012-08-23 9:50 ` [PATCH 1/2] Append "." in error message Yao Qi
2012-08-23 9:50 ` [PATCH 2/2] Remove pass in skip_unwinder_tests Yao Qi
2012-08-23 10:52 ` Pedro Alves
2012-08-23 12:29 ` Yao Qi
2012-08-23 18:03 ` Pedro Alves
2012-08-24 13:38 ` Jan Kratochvil
2012-08-24 15:41 ` Pedro Alves
2012-08-24 16:19 ` Jan Kratochvil
2012-08-24 16:53 ` Pedro Alves
2012-08-24 16:57 ` Pedro Alves
2012-08-24 17:12 ` Jan Kratochvil
2012-08-27 10:33 ` Yao Qi
2012-08-27 13:07 ` Jan Kratochvil
2012-08-27 15:15 ` Yao Qi
2012-08-27 15:57 ` Jan Kratochvil
2012-08-24 13:34 ` [PATCH 1/2] Append "." in error message Jan Kratochvil
2012-08-24 13:40 ` RFC: consolidate checks for _Unwind_DebugHook in test suite Jan Kratochvil
2012-08-24 13:54 ` Tom Tromey
2012-08-24 14:08 ` Jan Kratochvil
2012-08-24 15:26 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87boicxnog.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox