From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11991 invoked by alias); 23 Aug 2012 09:50:15 -0000 Received: (qmail 11980 invoked by uid 22791); 23 Aug 2012 09:50:14 -0000 X-SWARE-Spam-Status: No, hits=-4.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 23 Aug 2012 09:50:00 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1T4U35-0006oG-IZ from Yao_Qi@mentor.com for gdb-patches@sourceware.org; Thu, 23 Aug 2012 02:49:59 -0700 Received: from SVR-ORW-FEM-02.mgc.mentorg.com ([147.34.96.206]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Thu, 23 Aug 2012 02:49:59 -0700 Received: from qiyao.dyndns.org.dyndns.org (147.34.91.1) by svr-orw-fem-02.mgc.mentorg.com (147.34.96.168) with Microsoft SMTP Server id 14.1.289.1; Thu, 23 Aug 2012 02:49:58 -0700 From: Yao Qi To: Subject: [PATCH 2/2] Remove pass in skip_unwinder_tests Date: Thu, 23 Aug 2012 09:50:00 -0000 Message-ID: <1345715389-20955-2-git-send-email-yao@codesourcery.com> In-Reply-To: <1345715389-20955-1-git-send-email-yao@codesourcery.com> References: <877gt1zbr5.fsf@fleche.redhat.com> <1345715389-20955-1-git-send-email-yao@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00646.txt.bz2 Hi, As we discussed, proc skip_unwinder_tests should not generate any FAIL or PASS in test summary, so this patch is a follow-up to to remove 'pass', and replace gdb_test_multiple with send_gdb/gdb_expect. With this patch applied, these PASS are disappeared in test result. -PASS: gdb.cp/nextoverthrow.exp: check for unwinder hook -PASS: gdb.cp/nextoverthrow.exp: check for stap probe in unwinder -PASS: gdb.java/jnpe.exp: check for unwinder hook -PASS: gdb.java/jnpe.exp: check for stap probe in unwinder gdb/testsuite: 2012-08-23 Yao Qi * lib/gdb.exp (skip_unwinder_tests): Replace 'gdb_test_multiple' with 'send_gdb' and 'gdb_expect'. Remove pass. --- gdb/testsuite/lib/gdb.exp | 13 +++++-------- 1 files changed, 5 insertions(+), 8 deletions(-) diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp index 0b02f76..99d6591 100644 --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -2102,25 +2102,22 @@ proc skip_unwinder_tests {} { global gdb_prompt set ok 1 - gdb_test_multiple "print _Unwind_DebugHook" "check for unwinder hook" { + + send_gdb "print _Unwind_DebugHook\n" + gdb_expect { -re "= .*no debug info.*_Unwind_DebugHook.*\r\n$gdb_prompt $" { - # Pass the test so we don't get bogus fails in the results. - pass "check for unwinder hook" set ok 0 } -re "= .*_Unwind_DebugHook.*\r\n$gdb_prompt $" { - pass "check for unwinder hook" } -re "No symbol .* in current context.\r\n$gdb_prompt $" { - # Pass the test so we don't get bogus fails in the results. - pass "check for unwinder hook" set ok 0 } } if {!$ok} { - gdb_test_multiple "info probe" "check for stap probe in unwinder" { + send_gdb "info probe\n" + gdb_expect { -re ".*libgcc.*unwind.*\r\n$gdb_prompt $" { - pass "check for stap probe in unwinder" set ok 1 } -re "\r\n$gdb_prompt $" { -- 1.7.7.6