From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29995 invoked by alias); 24 Aug 2012 13:38:10 -0000 Received: (qmail 29886 invoked by uid 22791); 24 Aug 2012 13:38:08 -0000 X-SWARE-Spam-Status: No, hits=-6.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 24 Aug 2012 13:37:55 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7ODbsHj017577 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 24 Aug 2012 09:37:54 -0400 Received: from host2.jankratochvil.net (ovpn-116-37.ams2.redhat.com [10.36.116.37]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q7ODboEg017710 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 24 Aug 2012 09:37:53 -0400 Date: Fri, 24 Aug 2012 13:38:00 -0000 From: Jan Kratochvil To: Yao Qi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] Remove pass in skip_unwinder_tests Message-ID: <20120824133738.GB5219@host2.jankratochvil.net> References: <877gt1zbr5.fsf@fleche.redhat.com> <1345715389-20955-1-git-send-email-yao@codesourcery.com> <1345715389-20955-2-git-send-email-yao@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1345715389-20955-2-git-send-email-yao@codesourcery.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00718.txt.bz2 On Thu, 23 Aug 2012 11:49:49 +0200, Yao Qi wrote: > As we discussed, proc skip_unwinder_tests should not generate any FAIL > or PASS in test summary, During comparison across releases and testsuite modes it makes the diffs more difficult to read: Running gdb/testsuite/gdb.java/jnpe.exp ... PASS: gdb.java/jnpe.exp: compilation jnpe.java -FAIL: gdb.java/jnpe.exp: check for unwinder hook PASS: gdb.java/jnpe.exp: disable SIGSEGV for next-over-NPE PASS: gdb.java/jnpe.exp: next over NPE -PASS: gdb.java/jnpe.exp: continue to success for next-over-NPE +FAIL: gdb.java/jnpe.exp: continue to success for next-over-NPE Has the last testcase regressed because the check "check for unwinder hook" is therefore no longer there? Does it PASS or FAIL now? etc. In other case: #gdb.java/jnpe.exp Running gdb/testsuite/gdb.java/jnpe.exp ... PASS: gdb.java/jnpe.exp: compilation jnpe.java -PASS: gdb.java/jnpe.exp: check for unwinder hook PASS: gdb.java/jnpe.exp: disable SIGSEGV for next-over-NPE PASS: gdb.java/jnpe.exp: next over NPE FAIL: gdb.java/jnpe.exp: continue to success for next-over-NPE It was clear before why the testcase failed - because its 'check for unwinder hook' PASSes which should not in RHEL-5 x86_64 -m32 mode (as debuginfo from gcc libraries is missing there). the testcase was doing: (gdb) print _Unwind_DebugHook^M $1 = {void(void, void)} 0x7ffff78d4a90 <_Unwind_DebugHook>^M (gdb) PASS: gdb.java/jnpe.exp: check for unwinder hook handle SIGSEGV nostop noprint^M Signal Stop Print Pass to program Description^M SIGSEGV No No Yes Segmentation fault^M (gdb) PASS: gdb.java/jnpe.exp: disable SIGSEGV for next-over-NPE Not is that "print _Unwind_DebugHook" a part of the "disable SIGSEGV for next-over-NPE" test? (gdb) print _Unwind_DebugHook^M $1 = {void(void, void)} 0x7ffff78d4a90 <_Unwind_DebugHook>^M (gdb) handle SIGSEGV nostop noprint^M Signal Stop Print Pass to program Description^M SIGSEGV No No Yes Segmentation fault^M (gdb) PASS: gdb.java/jnpe.exp: disable SIGSEGV for next-over-NPE I do not see removing of useful messages to be much improvement. I understand it was checked in with a good intention. Jan