Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: teawater@gmail.com
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA/RFC] mips tracepoint: fix Bug 12013
Date: Sun, 19 Dec 2010 10:39:00 -0000	[thread overview]
Message-ID: <201012191039.oBJAdNBN010655@glazunov.sibelius.xs4all.nl> (raw)
In-Reply-To: <AANLkTi=qR1WV4c3G3QYmsH0fF2G7Z+J4uRM0iwff+DYh@mail.gmail.com>	(message from Hui Zhu on Sun, 19 Dec 2010 16:35:59 +0800)

> From: Hui Zhu <teawater@gmail.com>
> Date: Sun, 19 Dec 2010 16:35:59 +0800
> 
> http://sourceware.org/bugzilla/show_bug.cgi?id=12013
> 
> This bug make mips tracepoint cannot trace the backtrace.
> 
> This patch to fix this issue with a directly way just remove the
> decline of access to the raw register names.
> 
> If you think it's not OK.  What about add a new interface to gdbarch
> to access to the raw register names.

It is a common trick to return an empty register name for a (raw)
register to hide the register from the user.  So I don't think this
diff is ok, since the goal obviously is to hide the raw registers in
mips in favour of the pseudo registers.

I'd say the proper way forward is to teach the trace code to handle
pseudo registers.

> 2010-12-19  Hui Zhu  <teawater@gmail.com>
> 
> 	* mips-tdep.c (mips_register_name): Remove the check.
> 	(mips_print_registers_info): Remove the gdb_assert.
> 


  reply	other threads:[~2010-12-19 10:39 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-19  8:36 Hui Zhu
2010-12-19 10:39 ` Mark Kettenis [this message]
2010-12-19 12:16   ` Hui Zhu
2010-12-21 14:45     ` Hui Zhu
2010-12-21 14:58       ` Mark Kettenis
2010-12-21 15:09         ` Hui Zhu
2010-12-21 15:42     ` Kevin Buettner
2010-12-21 15:59       ` Hui Zhu
2010-12-22  6:04         ` Kevin Buettner
2010-12-22  7:12           ` Hui Zhu
2010-12-22 16:20             ` Kevin Buettner
2010-12-23  3:33               ` Hui Zhu
2010-12-27 13:20                 ` Hui Zhu
2010-12-27 13:56                   ` Joel Brobecker
2010-12-28  4:43                     ` Hui Zhu
2010-12-22 11:27           ` Pedro Alves
2010-12-25 19:10             ` Hui Zhu
2010-12-27 13:52               ` Pedro Alves
2010-12-28  9:52                 ` Hui Zhu
2010-12-28 10:30                   ` Pedro Alves
2010-12-28 17:09                     ` Hui Zhu
2010-12-28 18:04                       ` Joel Brobecker
2010-12-28 19:05                         ` Pedro Alves
2010-12-28 19:07                           ` Pedro Alves
2010-12-29  8:10                             ` Hui Zhu
2010-12-29 13:06                               ` Pedro Alves
2010-12-29 16:09                                 ` Hui Zhu
2010-12-29 17:57                                   ` Pedro Alves
2010-12-30  8:00                                     ` Hui Zhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201012191039.oBJAdNBN010655@glazunov.sibelius.xs4all.nl \
    --to=mark.kettenis@xs4all.nl \
    --cc=gdb-patches@sourceware.org \
    --cc=teawater@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox