Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Hui Zhu <teawater@gmail.com>
To: Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sourceware.org, Mark Kettenis <mark.kettenis@xs4all.nl>
Subject: Re: [RFA/RFC] mips tracepoint: fix Bug 12013
Date: Tue, 21 Dec 2010 15:59:00 -0000	[thread overview]
Message-ID: <AANLkTin6R0659AefYY+WxcSUtxV3M5uteuq0vkLFK-ea@mail.gmail.com> (raw)
In-Reply-To: <20101221084248.1c922955@mesquite.lan>

On Tue, Dec 21, 2010 at 23:42, Kevin Buettner <kevinb@redhat.com> wrote:
> On Sun, 19 Dec 2010 20:15:59 +0800
> Hui Zhu <teawater@gmail.com> wrote:
>
>> > It is a common trick to return an empty register name for a (raw)
>> > register to hide the register from the user. __So I don't think this
>> > diff is ok, since the goal obviously is to hide the raw registers in
>> > mips in favour of the pseudo registers.
>>
>> Could you tell me what this hide for?  I didn't find who get some
>> advantage form this part?
>
> I agree with Mark.  We do not want to expose the MIPS raw registers
> directly to the user.
>
> It is possible to debug a 64-bit device using a 32-bit programming
> model.  In such instances, the raw registers are configured to be
> 64-bits wide, while the pseudo registers are configured to be 32-bits
> wide.  The registers that the user sees - the pseudo registers - match
> the user's expectations given the programming model being used.

Thanks.  Do you think I can add a special name for these raw registers
then other part can use this raw register if need.

Thanks,
Hui

>
> Your patch exposes the raw registers in such a way that errant code
> (within GDB) could present the user with an inconsistent view of the
> registers.  This, in my opinion, is not desirable.
>
> Please revert your patch and, in the future, wait until a consensus is
> achieved before comitting your work.
>
> Kevin
>


  reply	other threads:[~2010-12-21 15:59 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-19  8:36 Hui Zhu
2010-12-19 10:39 ` Mark Kettenis
2010-12-19 12:16   ` Hui Zhu
2010-12-21 14:45     ` Hui Zhu
2010-12-21 14:58       ` Mark Kettenis
2010-12-21 15:09         ` Hui Zhu
2010-12-21 15:42     ` Kevin Buettner
2010-12-21 15:59       ` Hui Zhu [this message]
2010-12-22  6:04         ` Kevin Buettner
2010-12-22  7:12           ` Hui Zhu
2010-12-22 16:20             ` Kevin Buettner
2010-12-23  3:33               ` Hui Zhu
2010-12-27 13:20                 ` Hui Zhu
2010-12-27 13:56                   ` Joel Brobecker
2010-12-28  4:43                     ` Hui Zhu
2010-12-22 11:27           ` Pedro Alves
2010-12-25 19:10             ` Hui Zhu
2010-12-27 13:52               ` Pedro Alves
2010-12-28  9:52                 ` Hui Zhu
2010-12-28 10:30                   ` Pedro Alves
2010-12-28 17:09                     ` Hui Zhu
2010-12-28 18:04                       ` Joel Brobecker
2010-12-28 19:05                         ` Pedro Alves
2010-12-28 19:07                           ` Pedro Alves
2010-12-29  8:10                             ` Hui Zhu
2010-12-29 13:06                               ` Pedro Alves
2010-12-29 16:09                                 ` Hui Zhu
2010-12-29 17:57                                   ` Pedro Alves
2010-12-30  8:00                                     ` Hui Zhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTin6R0659AefYY+WxcSUtxV3M5uteuq0vkLFK-ea@mail.gmail.com \
    --to=teawater@gmail.com \
    --cc=gdb-patches@sourceware.org \
    --cc=kevinb@redhat.com \
    --cc=mark.kettenis@xs4all.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox