Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Hui Zhu <teawater@gmail.com>
To: gdb-patches ml <gdb-patches@sourceware.org>
Subject: [RFA/RFC] mips tracepoint: fix Bug 12013
Date: Sun, 19 Dec 2010 08:36:00 -0000	[thread overview]
Message-ID: <AANLkTi=qR1WV4c3G3QYmsH0fF2G7Z+J4uRM0iwff+DYh@mail.gmail.com> (raw)

http://sourceware.org/bugzilla/show_bug.cgi?id=12013

This bug make mips tracepoint cannot trace the backtrace.

This patch to fix this issue with a directly way just remove the
decline of access to the raw register names.

If you think it's not OK.  What about add a new interface to gdbarch
to access to the raw register names.

Thanks,
Hui


2010-12-19  Hui Zhu  <teawater@gmail.com>

	* mips-tdep.c (mips_register_name): Remove the check.
	(mips_print_registers_info): Remove the gdb_assert.

---
 mips-tdep.c |    6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

--- a/mips-tdep.c
+++ b/mips-tdep.c
@@ -453,11 +453,8 @@ mips_register_name (struct gdbarch *gdba

   enum mips_abi abi = mips_abi (gdbarch);

-  /* Map [gdbarch_num_regs .. 2*gdbarch_num_regs) onto the raw registers,
-     but then don't make the raw register names visible.  */
+  /* Map [gdbarch_num_regs .. 2*gdbarch_num_regs) onto the raw registers.  */
   int rawnum = regno % gdbarch_num_regs (gdbarch);
-  if (regno < gdbarch_num_regs (gdbarch))
-    return "";

   /* The MIPS integer registers are always mapped from 0 to 31.  The
      names of the registers (which reflects the conventions regarding
@@ -4774,7 +4771,6 @@ mips_print_registers_info (struct gdbarc
 {
   if (regnum != -1)		/* do one specified register */
     {
-      gdb_assert (regnum >= gdbarch_num_regs (gdbarch));
       if (*(gdbarch_register_name (gdbarch, regnum)) == '\0')
 	error (_("Not a valid register for the current processor type"));


             reply	other threads:[~2010-12-19  8:36 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-19  8:36 Hui Zhu [this message]
2010-12-19 10:39 ` Mark Kettenis
2010-12-19 12:16   ` Hui Zhu
2010-12-21 14:45     ` Hui Zhu
2010-12-21 14:58       ` Mark Kettenis
2010-12-21 15:09         ` Hui Zhu
2010-12-21 15:42     ` Kevin Buettner
2010-12-21 15:59       ` Hui Zhu
2010-12-22  6:04         ` Kevin Buettner
2010-12-22  7:12           ` Hui Zhu
2010-12-22 16:20             ` Kevin Buettner
2010-12-23  3:33               ` Hui Zhu
2010-12-27 13:20                 ` Hui Zhu
2010-12-27 13:56                   ` Joel Brobecker
2010-12-28  4:43                     ` Hui Zhu
2010-12-22 11:27           ` Pedro Alves
2010-12-25 19:10             ` Hui Zhu
2010-12-27 13:52               ` Pedro Alves
2010-12-28  9:52                 ` Hui Zhu
2010-12-28 10:30                   ` Pedro Alves
2010-12-28 17:09                     ` Hui Zhu
2010-12-28 18:04                       ` Joel Brobecker
2010-12-28 19:05                         ` Pedro Alves
2010-12-28 19:07                           ` Pedro Alves
2010-12-29  8:10                             ` Hui Zhu
2010-12-29 13:06                               ` Pedro Alves
2010-12-29 16:09                                 ` Hui Zhu
2010-12-29 17:57                                   ` Pedro Alves
2010-12-30  8:00                                     ` Hui Zhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTi=qR1WV4c3G3QYmsH0fF2G7Z+J4uRM0iwff+DYh@mail.gmail.com' \
    --to=teawater@gmail.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox