From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2619 invoked by alias); 19 Dec 2010 10:39:37 -0000 Received: (qmail 2611 invoked by uid 22791); 19 Dec 2010 10:39:36 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 19 Dec 2010 10:39:31 +0000 Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3) with ESMTP id oBJAdO64017052; Sun, 19 Dec 2010 11:39:24 +0100 (CET) Received: (from kettenis@localhost) by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3/Submit) id oBJAdNBN010655; Sun, 19 Dec 2010 11:39:23 +0100 (CET) Date: Sun, 19 Dec 2010 10:39:00 -0000 Message-Id: <201012191039.oBJAdNBN010655@glazunov.sibelius.xs4all.nl> From: Mark Kettenis To: teawater@gmail.com CC: gdb-patches@sourceware.org In-reply-to: (message from Hui Zhu on Sun, 19 Dec 2010 16:35:59 +0800) Subject: Re: [RFA/RFC] mips tracepoint: fix Bug 12013 References: Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-12/txt/msg00356.txt.bz2 > From: Hui Zhu > Date: Sun, 19 Dec 2010 16:35:59 +0800 > > http://sourceware.org/bugzilla/show_bug.cgi?id=12013 > > This bug make mips tracepoint cannot trace the backtrace. > > This patch to fix this issue with a directly way just remove the > decline of access to the raw register names. > > If you think it's not OK. What about add a new interface to gdbarch > to access to the raw register names. It is a common trick to return an empty register name for a (raw) register to hide the register from the user. So I don't think this diff is ok, since the goal obviously is to hide the raw registers in mips in favour of the pseudo registers. I'd say the proper way forward is to teach the trace code to handle pseudo registers. > 2010-12-19 Hui Zhu > > * mips-tdep.c (mips_register_name): Remove the check. > (mips_print_registers_info): Remove the gdb_assert. >