Re: Patch : gdbserver get_image_name on CE

[Pedro Alves <pedro@codesourcery.com>]

On Saturday 13 June 2009 15:29:45, Danny Backx wrote:
> 1. Initialize the breakpoint structure to the right instruction.

This is fine.  All that commenting fuss about "int 3" is
really unnecessary though.  If it was any other instruction other than
0xcc I'd be surprised.

> 2. Handle a case where the inferior refuses to start. See the
>    code after WaitForDebugEvent in win32-low.c .

This is quite mystifying.  Do you have more details on this?

> 3. Setjmp won't work on this platform, I've "#if 0"-ed it out.
>    Clearly not the right solution. Comment please.

What does "won't work on this platform" mean?  If longjmp
doesn't work, then you probably have a bug in your
headers or import libs?  I'd suspect _JBLEN in the
mingw headers.

> 4. Handle the failing call to GetThreadContext.

Seems reasonable.

> 5. Read the DLL names in a way that works on x86.


Could you please post your next patches in unified format
please?  (cvs diff -up).

IIRC, psapi.dll does exist on WinCE, but it is
not bundled with the OS usually.  If I'm not confusing
it with some other dll, I think I have it for ARM, gotten
from some MSFT redistributable, and it does work.

Could you please take a look at the GNU coding
conventions, and reformat appropriately, please?

 http://www.gnu.org/prep/standards/standards.html#Writing-C

-- 
Pedro Alves