From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 759 invoked by alias); 13 Jun 2009 18:05:25 -0000 Received: (qmail 751 invoked by uid 22791); 13 Jun 2009 18:05:24 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 13 Jun 2009 18:05:16 +0000 Received: (qmail 12576 invoked from network); 13 Jun 2009 18:05:14 -0000 Received: from unknown (HELO orlando.local) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 13 Jun 2009 18:05:14 -0000 From: Pedro Alves To: gdb-patches@sourceware.org, danny.backx@scarlet.be Subject: Re: Patch : gdbserver get_image_name on CE Date: Sat, 13 Jun 2009 18:05:00 -0000 User-Agent: KMail/1.9.10 References: <1244903385.20290.9.camel@pavilion> In-Reply-To: <1244903385.20290.9.camel@pavilion> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Message-Id: <200906131905.30933.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00360.txt.bz2 On Saturday 13 June 2009 15:29:45, Danny Backx wrote: > 1. Initialize the breakpoint structure to the right instruction. This is fine. All that commenting fuss about "int 3" is really unnecessary though. If it was any other instruction other than 0xcc I'd be surprised. > 2. Handle a case where the inferior refuses to start. See the > =A0 =A0code after WaitForDebugEvent in win32-low.c . This is quite mystifying. Do you have more details on this? > 3. Setjmp won't work on this platform, I've "#if 0"-ed it out. > =A0 =A0Clearly not the right solution. Comment please. What does "won't work on this platform" mean? If longjmp doesn't work, then you probably have a bug in your headers or import libs? I'd suspect _JBLEN in the mingw headers. > 4. Handle the failing call to GetThreadContext. Seems reasonable. > 5. Read the DLL names in a way that works on x86. Could you please post your next patches in unified format please? (cvs diff -up). IIRC, psapi.dll does exist on WinCE, but it is not bundled with the OS usually. If I'm not confusing it with some other dll, I think I have it for ARM, gotten from some MSFT redistributable, and it does work. Could you please take a look at the GNU coding conventions, and reformat appropriately, please? http://www.gnu.org/prep/standards/standards.html#Writing-C --=20 Pedro Alves