Re: Patch : gdbserver get_image_name on CE

[Danny Backx <danny.backx@scarlet.be>]

On Sun, 2009-06-07 at 19:16 +0100, Pedro Alves wrote:
> On Sunday 07 June 2009 19:01:39, Danny Backx wrote:
> 
> > Feel free to ignore these patches until they're complete, if that is a
> > better idea. 
> 
> It's fine to send unfinished patches for comments, if you'd like, but
> please say so explicitly, so I don't waste time trying to understand
> what they're for, for nothing.
> 
> > I sent this one separately because it looked contained. 
> 
> Thanks for doing that.  Splitting self contained patches is
> always good.

Excellent news : I just figured out why gdbserver was failing on CE/x86
where the same code worked for ARM.

The GetThreadContext call looked different between win32-i386-low.c and
its ARM equivalent :

  th->context.ContextFlags = 
    CONTEXT_FULL |
    CONTEXT_FLOATING_POINT |
    CONTEXT_EXTENDED_REGISTERS |
    CONTEXT_DEBUG_REGISTERS;
  GetThreadContext (th->h, &th->context);

On ARM, only CONTEXT_FULL and CONTEXT_FLOATING_POINT were used. The call
on x86 returned error 87 (ERROR_INVALID_PARAMETER) but MSDN doesn't
contain clues as to what that means.

I'll try to figure out whether this breaks anything, but at first sight
this small change (and a couple of others I have yet to submit) makes
gdbserver work.

	Danny
-- 
Danny Backx ; danny.backx - at - scarlet.be ; http://danny.backx.info