Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [RFA] Fix typo in type of parameter "w" in print_wchar...
@ 2009-04-25  0:37 Joel Brobecker
  2009-04-25  8:50 ` Mark Kettenis
  0 siblings, 1 reply; 7+ messages in thread
From: Joel Brobecker @ 2009-04-25  0:37 UTC (permalink / raw)
  To: gdb-patches

[-- Attachment #1: Type: text/plain, Size: 1039 bytes --]

I think this is the last issue I've found so far with character set
conversions and printing...

This one occurs on AIX while trying to print a simple ascii string.
The output looks like this:

    (gdb) p __gnat_version 
    $3 = "

The problem turned out to be pretty straightforward, once I got to
understand how things are supposed to work.

Basically, for every character in our string, we call print_wchar
to push the equivalent wchar on our itermediate wchar buffer.
The issue is that we had the wrong type for the wchar (gdb_wint_t
instead of gdb_wchar_t). gdb_wint_t is 4bytes long whereas gdb_wchar_t
is 2 bytes long. So when we do the pushing:

      obstack_grow (output, &w, sizeof (gdb_wchar_t));

We only push 2 bytes of the 4 bytes that w got accidently promoted to.
On ppc-aix, it's big endian, so we end up always pushing zeros...

2009-04-24  Joel Brobecker  <brobecker@adacore.com>

        * c-lang.c (print_wchar): Use the correct type for parameter "w".

I'm currently testing the patch on x86_64-linux...

-- 
Joel

[-- Attachment #2: c-lang.diff --]
[-- Type: text/x-diff, Size: 453 bytes --]

diff --git a/gdb/c-lang.c b/gdb/c-lang.c
index 027e9b2..5fe04de 100644
--- a/gdb/c-lang.c
+++ b/gdb/c-lang.c
@@ -156,7 +156,7 @@ append_string_as_wide (const char *string, struct obstack *output)
    escapes across calls.  */
 
 static void
-print_wchar (gdb_wint_t w, const gdb_byte *orig, int orig_len,
+print_wchar (gdb_wchar_t w, const gdb_byte *orig, int orig_len,
 	     int width, struct obstack *output, int quoter,
 	     int *need_escapep)
 {

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2009-05-13  9:43 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-04-25  0:37 [RFA] Fix typo in type of parameter "w" in print_wchar Joel Brobecker
2009-04-25  8:50 ` Mark Kettenis
2009-05-07 18:38   ` Joel Brobecker
2009-05-07 18:53     ` Mark Kettenis
2009-05-07 20:48       ` Joel Brobecker
2009-05-12  8:06     ` Joel Brobecker
2009-05-13  9:43       ` Joel Brobecker

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox