Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: brobecker@adacore.com
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Fix typo in type of parameter "w" in print_wchar...
Date: Thu, 07 May 2009 18:53:00 -0000	[thread overview]
Message-ID: <200905071852.n47IqbtU010728@brahms.sibelius.xs4all.nl> (raw)
In-Reply-To: <20090507183753.GE659@adacore.com> (message from Joel Brobecker 	on Thu, 7 May 2009 11:37:53 -0700)

> Date: Thu, 7 May 2009 11:37:53 -0700
> From: Joel Brobecker <brobecker@adacore.com>
> 
> > I think this is wrong.  The type of a single wide character is wint_t
> > instead of wchar_t such that it can properly hold WEOF, much in the
> > same way as the "normal" character functions use int instead of char.
> 
> Thanks for the hint, Mark.  Does the following look correct to you?
> I've just tested that it also fixes the issue on AIX, and I got no
> regression on amd64-linux.
> 
> 2009-05-07  Joel Brobecker  <brobecker@adacore.com>
> 
>         * c-lang.c (print_wchar): Convert w into a gdb_wchar_t before
>         pushing it on the output obstack.
> 

> +      gdb_wchar_t wchar = (gdb_wchar_t) w;

Is that cast necessary?

Otherwise, this looks excellent to me.


  reply	other threads:[~2009-05-07 18:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-25  0:37 Joel Brobecker
2009-04-25  8:50 ` Mark Kettenis
2009-05-07 18:38   ` Joel Brobecker
2009-05-07 18:53     ` Mark Kettenis [this message]
2009-05-07 20:48       ` Joel Brobecker
2009-05-12  8:06     ` Joel Brobecker
2009-05-13  9:43       ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200905071852.n47IqbtU010728@brahms.sibelius.xs4all.nl \
    --to=mark.kettenis@xs4all.nl \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox