From: Joel Brobecker <brobecker@adacore.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Fix typo in type of parameter "w" in print_wchar...
Date: Thu, 07 May 2009 20:48:00 -0000 [thread overview]
Message-ID: <20090507204818.GG659@adacore.com> (raw)
In-Reply-To: <200905071852.n47IqbtU010728@brahms.sibelius.xs4all.nl>
> > + gdb_wchar_t wchar = (gdb_wchar_t) w;
>
> Is that cast necessary?
Probably not. I just assumed I needed one, I don't know why.
> Otherwise, this looks excellent to me.
Thanks! I'll wait for a few more days to give Tom some time to comment
on this as well, and then commit (with the cast removed).
--
Joel
next prev parent reply other threads:[~2009-05-07 20:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-25 0:37 Joel Brobecker
2009-04-25 8:50 ` Mark Kettenis
2009-05-07 18:38 ` Joel Brobecker
2009-05-07 18:53 ` Mark Kettenis
2009-05-07 20:48 ` Joel Brobecker [this message]
2009-05-12 8:06 ` Joel Brobecker
2009-05-13 9:43 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090507204818.GG659@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox