From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-63600-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 10757 invoked by alias); 7 May 2009 20:48:28 -0000
Received: (qmail 10744 invoked by uid 22791); 7 May 2009 20:48:27 -0000
X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 	tests=AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 07 May 2009 20:48:23 +0000
Received: from localhost (localhost.localdomain [127.0.0.1]) 	by filtered-rock.gnat.com (Postfix) with ESMTP id 2430C2BAB95; 	Thu,  7 May 2009 16:48:21 -0400 (EDT)
Received: from rock.gnat.com ([127.0.0.1]) 	by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) 	with LMTP id 8hFura9RITgI; Thu,  7 May 2009 16:48:21 -0400 (EDT)
Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) 	by rock.gnat.com (Postfix) with ESMTP id CD8382BAAC4; 	Thu,  7 May 2009 16:48:20 -0400 (EDT)
Received: by joel.gnat.com (Postfix, from userid 1000) 	id 99F84F5900; Thu,  7 May 2009 13:48:18 -0700 (PDT)
Date: Thu, 07 May 2009 20:48:00 -0000
From: Joel Brobecker <brobecker@adacore.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Fix typo in type of parameter "w" in print_wchar...
Message-ID: <20090507204818.GG659@adacore.com>
References: <20090425003658.GA32745@adacore.com> <200904250849.n3P8n5BU002469@brahms.sibelius.xs4all.nl> <20090507183753.GE659@adacore.com> <200905071852.n47IqbtU010728@brahms.sibelius.xs4all.nl>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200905071852.n47IqbtU010728@brahms.sibelius.xs4all.nl>
User-Agent: Mutt/1.5.18 (2008-05-17)
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-05/txt/msg00163.txt.bz2

> > +      gdb_wchar_t wchar = (gdb_wchar_t) w;
> 
> Is that cast necessary?

Probably not. I just assumed I needed one, I don't know why.

> Otherwise, this looks excellent to me.

Thanks! I'll wait for a few more days to give Tom some time to comment
on this as well, and then commit (with the cast removed).

-- 
Joel