[RFA] (dump_raw_expression): Print note if non-NULL.

[RFA] (dump_raw_expression): Print note if non-NULL.

[Doug Evans]

Hi.

I found this while researching a bug.
The parameter "note" is unused in dump_raw_expression.

The other way to go, obviously, is to remove the parameter.
I like the fact that parse_exp_in_context() prints before/after
versions of the expression, and I like the inclusion of
the explanatory "before conversion to prefix form" text.
But I also don't want to put this text in dump_raw_expression itself.
So I kept the parameter.

parse.c:
  if (expressiondebug)
    dump_raw_expression (expout, gdb_stdlog,
			 "before conversion to prefix form");

  subexp = prefixify_expression (expout);
  if (out_subexp)
    *out_subexp = subexp;

  current_language->la_post_parser (&expout, void_context_p);

  if (expressiondebug)
    dump_prefix_expression (expout, gdb_stdlog);


Ok to check in?

2009-03-17  Doug Evans  <dje@google.com>

	* expprint.c (dump_raw_expression): Print note if non-NULL.

Index: expprint.c
===================================================================
RCS file: /cvs/src/src/gdb/expprint.c,v
retrieving revision 1.35
diff -u -p -u -p -r1.35 expprint.c
--- expprint.c	3 Jan 2009 05:57:51 -0000	1.35
+++ expprint.c	17 Mar 2009 21:52:30 -0000
@@ -802,6 +802,9 @@ op_name_standard (enum exp_opcode opcode
     }
 }
 
+/* Print a raw dump of expression EXP to STREAM.
+   NOTE, if non-NULL, is printed as extra explanatory text.  */
+
 void
 dump_raw_expression (struct expression *exp, struct ui_file *stream,
 		     char *note)
@@ -813,7 +816,9 @@ dump_raw_expression (struct expression *
 
   fprintf_filtered (stream, "Dump of expression @ ");
   gdb_print_host_address (exp, stream);
-  fprintf_filtered (stream, "'\n\tLanguage %s, %d elements, %ld bytes each.\n",
+  if (note)
+    fprintf_filtered (stream, ", %s:", note);
+  fprintf_filtered (stream, "\n\tLanguage %s, %d elements, %ld bytes each.\n",
 		    exp->language_defn->la_name, exp->nelts,
 		    (long) sizeof (union exp_element));
   fprintf_filtered (stream, "\t%5s  %20s  %16s  %s\n", "Index", "Opcode",

Re: [RFA] (dump_raw_expression): Print note if non-NULL.

[Tom Tromey]

>>>>> "Doug" == Doug Evans <dje@google.com> writes:

Doug> Ok to check in?
Doug> 2009-03-17  Doug Evans  <dje@google.com>
Doug> 	* expprint.c (dump_raw_expression): Print note if non-NULL.

Looks good to me, please go ahead.

Doug> -  fprintf_filtered (stream, "'\n\tLanguage %s, %d elements, %ld bytes each.\n",
Doug> +  if (note)
Doug> +    fprintf_filtered (stream, ", %s:", note);
Doug> +  fprintf_filtered (stream, "\n\tLanguage %s, %d elements, %ld bytes each.\n",

I notice that this removes a single quote (see the old fprintf_filtered).
But, I can't see why we would want that anyway.

Tom

Re: [RFA] (dump_raw_expression): Print note if non-NULL.

[Doug Evans]

On Tue, Mar 17, 2009 at 6:23 PM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Doug" == Doug Evans <dje@google.com> writes:
>
> Doug> Ok to check in?
> Doug> 2009-03-17  Doug Evans  <dje@google.com>
> Doug>   * expprint.c (dump_raw_expression): Print note if non-NULL.
>
> Looks good to me, please go ahead.
>
> Doug> -  fprintf_filtered (stream, "'\n\tLanguage %s, %d elements, %ld bytes each.\n",
> Doug> +  if (note)
> Doug> +    fprintf_filtered (stream, ", %s:", note);
> Doug> +  fprintf_filtered (stream, "\n\tLanguage %s, %d elements, %ld bytes each.\n",
>
> I notice that this removes a single quote (see the old fprintf_filtered).
> But, I can't see why we would want that anyway.

The single quote is a left over from an earlier version.