From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17178 invoked by alias); 17 Mar 2009 22:04:45 -0000 Received: (qmail 17169 invoked by uid 22791); 17 Mar 2009 22:04:43 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.45.13) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 17 Mar 2009 22:04:38 +0000 Received: from spaceape11.eur.corp.google.com (spaceape11.eur.corp.google.com [172.28.16.145]) by smtp-out.google.com with ESMTP id n2HM4Zie029313 for ; Tue, 17 Mar 2009 15:04:36 -0700 Received: from localhost (ruffy.mtv.corp.google.com [172.18.118.116]) by spaceape11.eur.corp.google.com with ESMTP id n2HM4YIX007584 for ; Tue, 17 Mar 2009 15:04:34 -0700 Received: by localhost (Postfix, from userid 67641) id BDAD01C7301; Tue, 17 Mar 2009 15:04:33 -0700 (PDT) To: gdb-patches@sourceware.org Subject: [RFA] (dump_raw_expression): Print note if non-NULL. Message-Id: <20090317220433.BDAD01C7301@localhost> Date: Tue, 17 Mar 2009 22:05:00 -0000 From: dje@google.com (Doug Evans) X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-03/txt/msg00338.txt.bz2 Hi. I found this while researching a bug. The parameter "note" is unused in dump_raw_expression. The other way to go, obviously, is to remove the parameter. I like the fact that parse_exp_in_context() prints before/after versions of the expression, and I like the inclusion of the explanatory "before conversion to prefix form" text. But I also don't want to put this text in dump_raw_expression itself. So I kept the parameter. parse.c: if (expressiondebug) dump_raw_expression (expout, gdb_stdlog, "before conversion to prefix form"); subexp = prefixify_expression (expout); if (out_subexp) *out_subexp = subexp; current_language->la_post_parser (&expout, void_context_p); if (expressiondebug) dump_prefix_expression (expout, gdb_stdlog); Ok to check in? 2009-03-17 Doug Evans * expprint.c (dump_raw_expression): Print note if non-NULL. Index: expprint.c =================================================================== RCS file: /cvs/src/src/gdb/expprint.c,v retrieving revision 1.35 diff -u -p -u -p -r1.35 expprint.c --- expprint.c 3 Jan 2009 05:57:51 -0000 1.35 +++ expprint.c 17 Mar 2009 21:52:30 -0000 @@ -802,6 +802,9 @@ op_name_standard (enum exp_opcode opcode } } +/* Print a raw dump of expression EXP to STREAM. + NOTE, if non-NULL, is printed as extra explanatory text. */ + void dump_raw_expression (struct expression *exp, struct ui_file *stream, char *note) @@ -813,7 +816,9 @@ dump_raw_expression (struct expression * fprintf_filtered (stream, "Dump of expression @ "); gdb_print_host_address (exp, stream); - fprintf_filtered (stream, "'\n\tLanguage %s, %d elements, %ld bytes each.\n", + if (note) + fprintf_filtered (stream, ", %s:", note); + fprintf_filtered (stream, "\n\tLanguage %s, %d elements, %ld bytes each.\n", exp->language_defn->la_name, exp->nelts, (long) sizeof (union exp_element)); fprintf_filtered (stream, "\t%5s %20s %16s %s\n", "Index", "Opcode",