From: Doug Evans <dje@google.com>
To: tromey@redhat.com
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] (dump_raw_expression): Print note if non-NULL.
Date: Wed, 18 Mar 2009 02:51:00 -0000 [thread overview]
Message-ID: <e394668d0903171950i76fc38e1xbedd998645183fcd@mail.gmail.com> (raw)
In-Reply-To: <m3fxhbk4if.fsf@fleche.redhat.com>
On Tue, Mar 17, 2009 at 6:23 PM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Doug" == Doug Evans <dje@google.com> writes:
>
> Doug> Ok to check in?
> Doug> 2009-03-17 Doug Evans <dje@google.com>
> Doug> * expprint.c (dump_raw_expression): Print note if non-NULL.
>
> Looks good to me, please go ahead.
>
> Doug> - fprintf_filtered (stream, "'\n\tLanguage %s, %d elements, %ld bytes each.\n",
> Doug> + if (note)
> Doug> + fprintf_filtered (stream, ", %s:", note);
> Doug> + fprintf_filtered (stream, "\n\tLanguage %s, %d elements, %ld bytes each.\n",
>
> I notice that this removes a single quote (see the old fprintf_filtered).
> But, I can't see why we would want that anyway.
The single quote is a left over from an earlier version.
prev parent reply other threads:[~2009-03-18 2:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-17 22:05 Doug Evans
2009-03-18 1:32 ` Tom Tromey
2009-03-18 2:51 ` Doug Evans [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e394668d0903171950i76fc38e1xbedd998645183fcd@mail.gmail.com \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox