From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-62244-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 31718 invoked by alias); 18 Mar 2009 02:50:53 -0000
Received: (qmail 31708 invoked by uid 22791); 18 Mar 2009 02:50:52 -0000
X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 	tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.45.13)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 18 Mar 2009 02:50:42 +0000
Received: from wpaz9.hot.corp.google.com (wpaz9.hot.corp.google.com [172.24.198.73]) 	by smtp-out.google.com with ESMTP id n2I2oews007176 	for <gdb-patches@sourceware.org>; Tue, 17 Mar 2009 19:50:40 -0700
Received: from wf-out-1314.google.com (wfd26.prod.google.com [10.142.4.26]) 	by wpaz9.hot.corp.google.com with ESMTP id n2I2ocJ5027791 	for <gdb-patches@sourceware.org>; Tue, 17 Mar 2009 19:50:39 -0700
Received: by wf-out-1314.google.com with SMTP id 26so351423wfd.32         for <gdb-patches@sourceware.org>; Tue, 17 Mar 2009 19:50:38 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.140.171.18 with SMTP id t18mr140619rve.95.1237344638646; Tue,  	17 Mar 2009 19:50:38 -0700 (PDT)
In-Reply-To: <m3fxhbk4if.fsf@fleche.redhat.com>
References: <20090317220433.BDAD01C7301@localhost> 	 <m3fxhbk4if.fsf@fleche.redhat.com>
Date: Wed, 18 Mar 2009 02:51:00 -0000
Message-ID: <e394668d0903171950i76fc38e1xbedd998645183fcd@mail.gmail.com>
Subject: Re: [RFA] (dump_raw_expression): Print note if non-NULL.
From: Doug Evans <dje@google.com>
To: tromey@redhat.com
Cc: gdb-patches@sourceware.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-System-Of-Record: true
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-03/txt/msg00354.txt.bz2

On Tue, Mar 17, 2009 at 6:23 PM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Doug" == Doug Evans <dje@google.com> writes:
>
> Doug> Ok to check in?
> Doug> 2009-03-17  Doug Evans  <dje@google.com>
> Doug>   * expprint.c (dump_raw_expression): Print note if non-NULL.
>
> Looks good to me, please go ahead.
>
> Doug> -  fprintf_filtered (stream, "'\n\tLanguage %s, %d elements, %ld bytes each.\n",
> Doug> +  if (note)
> Doug> +    fprintf_filtered (stream, ", %s:", note);
> Doug> +  fprintf_filtered (stream, "\n\tLanguage %s, %d elements, %ld bytes each.\n",
>
> I notice that this removes a single quote (see the old fprintf_filtered).
> But, I can't see why we would want that anyway.

The single quote is a left over from an earlier version.