From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-62239-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 6931 invoked by alias); 18 Mar 2009 01:24:06 -0000
Received: (qmail 6922 invoked by uid 22791); 18 Mar 2009 01:24:05 -0000
X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 	tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 18 Mar 2009 01:23:59 +0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) 	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n2I1Ntpq019158; 	Tue, 17 Mar 2009 21:23:55 -0400
Received: from opsy.redhat.com (vpn-14-28.rdu.redhat.com [10.11.14.28]) 	by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n2I1NtYG012139; 	Tue, 17 Mar 2009 21:23:55 -0400
Received: by opsy.redhat.com (Postfix, from userid 500) 	id 98949508085; Tue, 17 Mar 2009 19:23:52 -0600 (MDT)
To: dje@google.com (Doug Evans)
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] (dump_raw_expression): Print note if non-NULL.
References: <20090317220433.BDAD01C7301@localhost>
From: Tom Tromey <tromey@redhat.com>
Reply-To: tromey@redhat.com
Date: Wed, 18 Mar 2009 01:32:00 -0000
In-Reply-To: <20090317220433.BDAD01C7301@localhost> (Doug Evans's message of "Tue\, 17 Mar 2009 15\:04\:33 -0700 \(PDT\)")
Message-ID: <m3fxhbk4if.fsf@fleche.redhat.com>
User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-03/txt/msg00349.txt.bz2

>>>>> "Doug" == Doug Evans <dje@google.com> writes:

Doug> Ok to check in?
Doug> 2009-03-17  Doug Evans  <dje@google.com>
Doug> 	* expprint.c (dump_raw_expression): Print note if non-NULL.

Looks good to me, please go ahead.

Doug> -  fprintf_filtered (stream, "'\n\tLanguage %s, %d elements, %ld bytes each.\n",
Doug> +  if (note)
Doug> +    fprintf_filtered (stream, ", %s:", note);
Doug> +  fprintf_filtered (stream, "\n\tLanguage %s, %d elements, %ld bytes each.\n",

I notice that this removes a single quote (see the old fprintf_filtered).
But, I can't see why we would want that anyway.

Tom