RFA: fix a memory leak in value.c

RFA: fix a memory leak in value.c

[Tom Tromey]

This patch fixes a small memory leak in value.c.

After the content-allocation change, values must be freed using
value_free, not xfree.

Built and regtested on x86-64 (compile farm).
Verified with valgrind.

Please review.

thanks,
Tom

2009-01-06  Tom Tromey  <tromey@redhat.com>

	* value.c (set_internalvar): Use value_free, not xfree.

diff --git a/gdb/value.c b/gdb/value.c
index 39df98e..1068f1d 100644
--- a/gdb/value.c
+++ b/gdb/value.c
@@ -931,7 +931,7 @@ set_internalvar (struct internalvar *var, struct value *val)
      something in the value chain (i.e., before release_value is
      called), because after the error free_all_values will get called before
      long.  */
-  xfree (var->value);
+  value_free (var->value);
   var->value = newval;
   var->endian = gdbarch_byte_order (current_gdbarch);
   release_value (newval);

Re: RFA: fix a memory leak in value.c

[Daniel Jacobowitz]

On Tue, Jan 06, 2009 at 03:23:14PM -0700, Tom Tromey wrote:
> This patch fixes a small memory leak in value.c.
> 
> After the content-allocation change, values must be freed using
> value_free, not xfree.
> 
> Built and regtested on x86-64 (compile farm).
> Verified with valgrind.
> 
> Please review.

OK, thanks.

-- 
Daniel Jacobowitz
CodeSourcery

Re: RFA: fix a memory leak in value.c

[Tom Tromey]

>>>>> "Daniel" == Daniel Jacobowitz <drow@false.org> writes:

>> After the content-allocation change, values must be freed using
>> value_free, not xfree.

Daniel> OK, thanks.

Thanks, I've checked this in.

Tom