From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6505 invoked by alias); 6 Jan 2009 23:29:25 -0000 Received: (qmail 6496 invoked by uid 22791); 6 Jan 2009 23:29:25 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 06 Jan 2009 23:29:19 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 64A3710D66; Tue, 6 Jan 2009 23:29:17 +0000 (GMT) Received: from caradoc.them.org (209.195.188.212.nauticom.net [209.195.188.212]) by nan.false.org (Postfix) with ESMTP id 55F9810D5C; Tue, 6 Jan 2009 23:29:17 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1LKLMK-0000PK-Rh; Tue, 06 Jan 2009 18:29:16 -0500 Date: Tue, 06 Jan 2009 23:29:00 -0000 From: Daniel Jacobowitz To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: RFA: fix a memory leak in value.c Message-ID: <20090106232916.GA1496@caradoc.them.org> Mail-Followup-To: Tom Tromey , gdb-patches@sourceware.org References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-01/txt/msg00062.txt.bz2 On Tue, Jan 06, 2009 at 03:23:14PM -0700, Tom Tromey wrote: > This patch fixes a small memory leak in value.c. > > After the content-allocation change, values must be freed using > value_free, not xfree. > > Built and regtested on x86-64 (compile farm). > Verified with valgrind. > > Please review. OK, thanks. -- Daniel Jacobowitz CodeSourcery