From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21983 invoked by alias); 6 Jan 2009 22:23:27 -0000 Received: (qmail 21975 invoked by uid 22791); 6 Jan 2009 22:23:27 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,KAM_MX,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 06 Jan 2009 22:23:23 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n06MNL84011935 for ; Tue, 6 Jan 2009 17:23:21 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n06MNLqf009508; Tue, 6 Jan 2009 17:23:21 -0500 Received: from opsy.redhat.com (vpn-12-46.rdu.redhat.com [10.11.12.46]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n06MNLMl025696; Tue, 6 Jan 2009 17:23:21 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id 6E9B6378095; Tue, 6 Jan 2009 15:23:14 -0700 (MST) To: gdb-patches@sourceware.org Subject: RFA: fix a memory leak in value.c From: Tom Tromey Reply-To: Tom Tromey Date: Tue, 06 Jan 2009 22:23:00 -0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-01/txt/msg00061.txt.bz2 This patch fixes a small memory leak in value.c. After the content-allocation change, values must be freed using value_free, not xfree. Built and regtested on x86-64 (compile farm). Verified with valgrind. Please review. thanks, Tom 2009-01-06 Tom Tromey * value.c (set_internalvar): Use value_free, not xfree. diff --git a/gdb/value.c b/gdb/value.c index 39df98e..1068f1d 100644 --- a/gdb/value.c +++ b/gdb/value.c @@ -931,7 +931,7 @@ set_internalvar (struct internalvar *var, struct value *val) something in the value chain (i.e., before release_value is called), because after the error free_all_values will get called before long. */ - xfree (var->value); + value_free (var->value); var->value = newval; var->endian = gdbarch_byte_order (current_gdbarch); release_value (newval);