From: Tom Tromey <tromey@redhat.com>
To: gdb-patches@sourceware.org
Subject: RFA: fix a memory leak in value.c
Date: Tue, 06 Jan 2009 22:23:00 -0000 [thread overview]
Message-ID: <m3wsd8846l.fsf@fleche.redhat.com> (raw)
This patch fixes a small memory leak in value.c.
After the content-allocation change, values must be freed using
value_free, not xfree.
Built and regtested on x86-64 (compile farm).
Verified with valgrind.
Please review.
thanks,
Tom
2009-01-06 Tom Tromey <tromey@redhat.com>
* value.c (set_internalvar): Use value_free, not xfree.
diff --git a/gdb/value.c b/gdb/value.c
index 39df98e..1068f1d 100644
--- a/gdb/value.c
+++ b/gdb/value.c
@@ -931,7 +931,7 @@ set_internalvar (struct internalvar *var, struct value *val)
something in the value chain (i.e., before release_value is
called), because after the error free_all_values will get called before
long. */
- xfree (var->value);
+ value_free (var->value);
var->value = newval;
var->endian = gdbarch_byte_order (current_gdbarch);
release_value (newval);
next reply other threads:[~2009-01-06 22:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-06 22:23 Tom Tromey [this message]
2009-01-06 23:29 ` Daniel Jacobowitz
2009-01-07 0:47 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3wsd8846l.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox