[patch] tui: initialize signal handler

[patch] tui: initialize signal handler

[Carlos Eduardo Seo]

[-- Attachment #1: Type: text/plain, Size: 565 bytes --]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello all

I noticed that the TUI signal handler isn't initialized anywhere. Here's
a patch to fix it. I'm not sure if this is the correct file to add this,
though.

What do you think?

Regards,

- --
Carlos Eduardo Seo
Software Engineer
IBM Linux Technology Center
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.7 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFG9G6Uqvq7Aov/qQARAoCxAJ9OlDthCDDQiviQUtLn8ssYBnSQGwCeJW5p
MnQvOGlkG1PReK9L8nQQGMs=
=FtxO
-----END PGP SIGNATURE-----

[-- Attachment #2: tui-sighandler.diff --]
[-- Type: text/x-patch, Size: 635 bytes --]

2007-09-21   Carlos Eduardo Seo <cseo@linux.vnet.ibm.com>

	gdb/tui/tui.c (tui_initialize_readline): initialize 
	TUI's SIGWINCH signal handler.

Index: src/gdb/tui/tui.c
===================================================================
--- src.orig/gdb/tui/tui.c
+++ src/gdb/tui/tui.c
@@ -309,6 +309,11 @@ tui_initialize_readline (void)
   int i;
   Keymap tui_ctlx_keymap;
 
+  struct sigaction old_winch;
+  memset (&old_winch, 0, sizeof (old_winch));
+  old_winch.sa_handler = &tui_sigwinch_handler;
+  sigaction (SIGWINCH, &old_winch, NULL);
+
   rl_initialize ();
 
   rl_add_defun ("tui-switch-mode", tui_rl_switch_mode, -1);

[-- Attachment #3: tui-sighandler.diff.sig --]
[-- Type: application/octet-stream, Size: 65 bytes --]

Re: [patch] tui: initialize signal handler

[Eli Zaretskii]

> Date: Fri, 21 Sep 2007 22:23:42 -0300
> From: Carlos Eduardo Seo <cseo@linux.vnet.ibm.com>
> 
> I noticed that the TUI signal handler isn't initialized anywhere. Here's
> a patch to fix it.

Thanks.

> What do you think?

I think it shouldn't use sigaction unconditionally, as the rest of GDB
doesn't.  It should at least test HAVE_SIGACTION and include an
alternative solution for when sigaction is not available.  See
remote-fileio.c for an example.

Re: [patch] tui: initialize signal handler

[Pedro Alves]

Carlos Eduardo Seo wrote:
> I noticed that the TUI signal handler isn't initialized anywhere. Here's
> a patch to fix it. I'm not sure if this is the correct file to add this,
> though.
> 
> What do you think?
> 

Thanks!  I wondered why it wouldn't resize :)

(Addicionally to Elli's remark, testing for ifdef SIGWINCH would be
a good idea too.)

I don't think tui_initialize_readline is the best place for this.

How about a new tui_initialize_win in tui-win.c, and call it from
next to where tui_initialize_readline is called in tui_init ?

Cheers,
Pedro Alves

Re: [patch] tui: initialize signal handler

[Carlos Eduardo Seo]

[-- Attachment #1: Type: text/plain, Size: 1040 bytes --]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1



Pedro Alves wrote:
> Carlos Eduardo Seo wrote:
>> I noticed that the TUI signal handler isn't initialized anywhere.
>> Here's
>> a patch to fix it. I'm not sure if this is the correct file to add
>> this,
>> though.
>>
>> What do you think?
>>
>
> Thanks!  I wondered why it wouldn't resize :)
>
> (Addicionally to Elli's remark, testing for ifdef SIGWINCH would be
> a good idea too.)
>
> I don't think tui_initialize_readline is the best place for this.
>
> How about a new tui_initialize_win in tui-win.c, and call it from
> next to where tui_initialize_readline is called in tui_init ?
>
> Cheers,
> Pedro Alves
>
>
Updated patch with your suggestions.

Regards,

- --
Carlos Eduardo Seo
Software Engineer
IBM Linux Technology Center
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.7 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFG9U0kqvq7Aov/qQARAmUjAJ4u5ZnggyNH8XDMRtc8HoL5zq5SNACeMhHy
Z9dB+dQQopxaTidh+LemuyI=
=rHwG
-----END PGP SIGNATURE-----


[-- Attachment #2: tui-sighandler.diff --]
[-- Type: text/x-patch, Size: 2097 bytes --]

2007-09-22   Carlos Eduardo Seo <cseo@linux.vnet.ibm.com>

	gdb/tui/tui-interp.c (tui_init): initialize 
	tui's SIGWINCH signal handler.
	gdb/tui/tui-win.c (tui_initialize_win): new 
	function for initializing tui's SIGWINCH signal 
	handler.
	gdb/tui/tui-win.h (tui_initialize_win): added


Index: src/gdb/tui/tui-interp.c
===================================================================
--- src.orig/gdb/tui/tui-interp.c
+++ src/gdb/tui/tui-interp.c
@@ -56,6 +56,7 @@ tui_init (void)
   tui_initialize_static_data ();
 
   tui_initialize_io ();
+  tui_initialize_win ();
   tui_initialize_readline ();
 
   return NULL;
Index: src/gdb/tui/tui-win.c
===================================================================
--- src.orig/gdb/tui/tui-win.c
+++ src/gdb/tui/tui-win.c
@@ -50,6 +50,8 @@
 #include <ctype.h>
 #include "readline/readline.h"
 
+#include <signal.h>
+
 /*******************************
 ** Static Local Decls
 ********************************/
@@ -802,6 +804,7 @@ tui_resize_all (void)
 }
 
 
+#ifdef SIGWINCH
 /* SIGWINCH signal handler for the tui.  This signal handler is always
    called, even when the readline package clears signals because it is
    set as the old_sigwinch() (TUI only).  */
@@ -813,6 +816,20 @@ tui_sigwinch_handler (int signal)
   tui_set_win_resized_to (TRUE);
 }
 
+/* Initializes SIGWINCH signal handler for the tui.  */
+void
+tui_initialize_win (void)
+{
+#ifdef HAVE_SIGACTION
+  struct sigaction old_winch;
+  memset (&old_winch, 0, sizeof (old_winch));
+  old_winch.sa_handler = &tui_sigwinch_handler;
+  sigaction (SIGWINCH, &old_winch, NULL);
+#else
+  signal (SIGWINCH, &tui_sigwinch_handler);
+#endif
+}
+#endif
 
 
 /*************************
Index: src/gdb/tui/tui-win.h
===================================================================
--- src.orig/gdb/tui/tui-win.h
+++ src/gdb/tui/tui-win.h
@@ -49,6 +49,8 @@ extern int tui_active_border_attrs;
 
 extern int tui_update_variables (void);
 
+extern void tui_initialize_win (void);
+
 /* Update gdb's knowledge of the terminal size.  */
 extern void tui_update_gdb_sizes (void);
 

[-- Attachment #3: tui-sighandler.diff.sig --]
[-- Type: application/octet-stream, Size: 65 bytes --]

Re: [patch] tui: initialize signal handler

[Eli Zaretskii]

> Date: Sat, 22 Sep 2007 14:13:09 -0300
> From: Carlos Eduardo Seo <cseo@linux.vnet.ibm.com>
> CC: gdb-patches@sourceware.org, eliz@gnu.org
> 
> +#ifdef SIGWINCH
>  /* SIGWINCH signal handler for the tui.  This signal handler is always
>     called, even when the readline package clears signals because it is
>     set as the old_sigwinch() (TUI only).  */
> @@ -813,6 +816,20 @@ tui_sigwinch_handler (int signal)
>    tui_set_win_resized_to (TRUE);
>  }
>  
> +/* Initializes SIGWINCH signal handler for the tui.  */
> +void
> +tui_initialize_win (void)
> +{
> +#ifdef HAVE_SIGACTION
> +  struct sigaction old_winch;
> +  memset (&old_winch, 0, sizeof (old_winch));
> +  old_winch.sa_handler = &tui_sigwinch_handler;
> +  sigaction (SIGWINCH, &old_winch, NULL);
> +#else
> +  signal (SIGWINCH, &tui_sigwinch_handler);
> +#endif
> +}
> +#endif

This is fine.  Thanks.

Re: [patch] tui: initialize signal handler

[Pedro Alves]

(Eli, Apologies for misspelling you name upthread.)

Carlos Eduardo Seo wrote:
> Updated patch with your suggestions.
> 
> 

Thanks.

You shouldn't wrap the whole tui_initialize_win in ifdef
SIGWINCH, but it's contents instead, else on a system
without SIGWINCH, you'll get an undefined reference to
tui_initialize_win.

Other than that, it looks good to me, but, you'll need approval
from a responsible or global maintainer.

> 2007-09-22   Carlos Eduardo Seo <cseo@linux.vnet.ibm.com>
             ^^^                  ^
It should be two spaces before and after the name.

>
> 	gdb/tui/tui-interp.c (tui_init): initialize
> 	tui's SIGWINCH signal handler.
> 	gdb/tui/tui-win.c (tui_initialize_win): new
> 	function for initializing tui's SIGWINCH signal
> 	handler.
> 	gdb/tui/tui-win.h (tui_initialize_win): added

Remove "gdb/" from the path of the changed files, since the path
is relative to the ChangeLog file location.  Add "* " in front,
Capitalize the sentences and finish them with a full stop. Eg:

2007-09-22  Carlos Eduardo Seo  <cseo@linux.vnet.ibm.com>

	* tui/tui-interp.c (tui_init): Initialize tui's
	SIGWINCH signal handler.
	* tui/tui-win.c (tui_initialize_win): New.
	function for initializing tui's SIGWINCH signal
	handler.
	* tui/tui-win.h (tui_initialize_win): Declare.

Cheers,
Pedro Alves

Re: [patch] tui: initialize signal handler

[Carlos Eduardo Seo]

[-- Attachment #1: Type: text/plain, Size: 429 bytes --]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Updated with you suggestions. Ok to commit now?

Regards,

- --
Carlos Eduardo Seo
Software Engineer
IBM Linux Technology Center
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.7 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFG9Wutqvq7Aov/qQARAmhKAJ9saBoP+CC/IuyIj+R1wA1QHFD5VACeKHtx
sfBjFEz6eoe9Vp7/5Uw5C6U=
=3Nhn
-----END PGP SIGNATURE-----


[-- Attachment #2: tui-sighandler.diff --]
[-- Type: text/x-patch, Size: 1888 bytes --]

2007-09-22  Carlos Eduardo Seo  <cseo@linux.vnet.ibm.com>

        * tui/tui-interp.c (tui_init): Initialize
        tui's SIGWINCH signal handler.
        * tui/tui-win.c (tui_initialize_win): New
        function for initializing tui's SIGWINCH signal
        handler.
        * tui/tui-win.h (tui_initialize_win): Declare


Index: src/gdb/tui/tui-interp.c
===================================================================
--- src.orig/gdb/tui/tui-interp.c
+++ src/gdb/tui/tui-interp.c
@@ -56,6 +56,7 @@ tui_init (void)
   tui_initialize_static_data ();
 
   tui_initialize_io ();
+  tui_initialize_win ();
   tui_initialize_readline ();
 
   return NULL;
Index: src/gdb/tui/tui-win.c
===================================================================
--- src.orig/gdb/tui/tui-win.c
+++ src/gdb/tui/tui-win.c
@@ -50,6 +50,8 @@
 #include <ctype.h>
 #include "readline/readline.h"
 
+#include <signal.h>
+
 /*******************************
 ** Static Local Decls
 ********************************/
@@ -813,6 +815,21 @@ tui_sigwinch_handler (int signal)
   tui_set_win_resized_to (TRUE);
 }
 
+/* Initializes SIGWINCH signal handler for the tui.  */
+void
+tui_initialize_win (void)
+{
+#ifdef SIGWINCH
+#ifdef SIGACTION
+  struct sigaction old_winch;
+  memset (&old_winch, 0, sizeof (old_winch));
+  old_winch.sa_handler = &tui_sigwinch_handler;
+  sigaction (SIGWINCH, &old_winch, NULL);
+#else
+  signal (SIGWINCH, &tui_sigwinch_handler);
+#endif
+#endif
+}
 
 
 /*************************
Index: src/gdb/tui/tui-win.h
===================================================================
--- src.orig/gdb/tui/tui-win.h
+++ src/gdb/tui/tui-win.h
@@ -49,6 +49,8 @@ extern int tui_active_border_attrs;
 
 extern int tui_update_variables (void);
 
+extern void tui_initialize_win (void);
+
 /* Update gdb's knowledge of the terminal size.  */
 extern void tui_update_gdb_sizes (void);
 

[-- Attachment #3: tui-sighandler.diff.sig --]
[-- Type: application/octet-stream, Size: 65 bytes --]

Re: [patch] tui: initialize signal handler

[Daniel Jacobowitz]

On Sat, Sep 22, 2007 at 04:23:26PM -0300, Carlos Eduardo Seo wrote:
> +#ifdef SIGACTION

#ifdef HAVE_SIGACTION

I don't think anything defines SIGACTION.  Otherwise, as Eli already
said, OK to commit :-)

-- 
Daniel Jacobowitz
CodeSourcery

Re: [patch] tui: initialize signal handler

[Carlos Eduardo Seo]

[-- Attachment #1: Type: text/plain, Size: 649 bytes --]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1



Daniel Jacobowitz wrote:
> On Sat, Sep 22, 2007 at 04:23:26PM -0300, Carlos Eduardo Seo wrote:
>> +#ifdef SIGACTION
>
> #ifdef HAVE_SIGACTION
>
> I don't think anything defines SIGACTION.  Otherwise, as Eli already
> said, OK to commit :-)
>
Whops... typo!

Corrected now. :)

- --
Carlos Eduardo Seo
Software Engineer
IBM Linux Technology Center
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.7 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFG9arPqvq7Aov/qQARAt7WAJ9BF+GF4oab+IKvi6l8eizgIGtulgCfZlqd
y/gvG5q1lxK5ggT63bvdAZE=
=SDP2
-----END PGP SIGNATURE-----


[-- Attachment #2: tui-sighandler.diff --]
[-- Type: text/x-patch, Size: 1893 bytes --]

2007-09-22  Carlos Eduardo Seo  <cseo@linux.vnet.ibm.com>

        * tui/tui-interp.c (tui_init): Initialize
        tui's SIGWINCH signal handler.
        * tui/tui-win.c (tui_initialize_win): New
        function for initializing tui's SIGWINCH signal
        handler.
        * tui/tui-win.h (tui_initialize_win): Declare


Index: src/gdb/tui/tui-interp.c
===================================================================
--- src.orig/gdb/tui/tui-interp.c
+++ src/gdb/tui/tui-interp.c
@@ -56,6 +56,7 @@ tui_init (void)
   tui_initialize_static_data ();
 
   tui_initialize_io ();
+  tui_initialize_win ();
   tui_initialize_readline ();
 
   return NULL;
Index: src/gdb/tui/tui-win.c
===================================================================
--- src.orig/gdb/tui/tui-win.c
+++ src/gdb/tui/tui-win.c
@@ -50,6 +50,8 @@
 #include <ctype.h>
 #include "readline/readline.h"
 
+#include <signal.h>
+
 /*******************************
 ** Static Local Decls
 ********************************/
@@ -813,6 +815,21 @@ tui_sigwinch_handler (int signal)
   tui_set_win_resized_to (TRUE);
 }
 
+/* Initializes SIGWINCH signal handler for the tui.  */
+void
+tui_initialize_win (void)
+{
+#ifdef SIGWINCH
+#ifdef HAVE_SIGACTION
+  struct sigaction old_winch;
+  memset (&old_winch, 0, sizeof (old_winch));
+  old_winch.sa_handler = &tui_sigwinch_handler;
+  sigaction (SIGWINCH, &old_winch, NULL);
+#else
+  signal (SIGWINCH, &tui_sigwinch_handler);
+#endif
+#endif
+}
 
 
 /*************************
Index: src/gdb/tui/tui-win.h
===================================================================
--- src.orig/gdb/tui/tui-win.h
+++ src/gdb/tui/tui-win.h
@@ -49,6 +49,8 @@ extern int tui_active_border_attrs;
 
 extern int tui_update_variables (void);
 
+extern void tui_initialize_win (void);
+
 /* Update gdb's knowledge of the terminal size.  */
 extern void tui_update_gdb_sizes (void);
 

[-- Attachment #3: tui-sighandler.diff.sig --]
[-- Type: application/octet-stream, Size: 65 bytes --]

Re: [patch] tui: initialize signal handler

[Carlos Eduardo Seo]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1



Carlos Eduardo Seo wrote:
>
>
> Daniel Jacobowitz wrote:
>> On Sat, Sep 22, 2007 at 04:23:26PM -0300, Carlos Eduardo Seo
>> wrote:
>>> +#ifdef SIGACTION
>> #ifdef HAVE_SIGACTION
>
>> I don't think anything defines SIGACTION.  Otherwise, as Eli
>> already said, OK to commit :-)
>
> Whops... typo!
>
> Corrected now. :)
>
Any news on this?

Thanks,

- --
Carlos Eduardo Seo
Software Engineer
IBM Linux Technology Center
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.7 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFG/ZfEqvq7Aov/qQARAs1dAJwIAsECN7TsgCHyIKdeP5NB3KsUNwCfY4e6
4HzRUjaC6TQaRSGRC5LdkMg=
=t6xu
-----END PGP SIGNATURE-----

Re: [patch] tui: initialize signal handler

[Daniel Jacobowitz]

On Fri, Sep 28, 2007 at 09:09:40PM -0300, Carlos Eduardo Seo wrote:
> Any news on this?

My understanding is that only Ulrich can check in patches from IBM
contributors.

-- 
Daniel Jacobowitz
CodeSourcery

Re: [patch] tui: initialize signal handler

[Ulrich Weigand]

Carlos Eduardo Seo wrote:

> 2007-09-22  Carlos Eduardo Seo  <cseo@linux.vnet.ibm.com>
> 
>         * tui/tui-interp.c (tui_init): Initialize
>         tui's SIGWINCH signal handler.
>         * tui/tui-win.c (tui_initialize_win): New
>         function for initializing tui's SIGWINCH signal
>         handler.
>         * tui/tui-win.h (tui_initialize_win): Declare

I've checked this in now.

Thanks,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com