Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Carlos Eduardo Seo <cseo@linux.vnet.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] tui: initialize signal handler
Date: Sat, 22 Sep 2007 07:34:00 -0000	[thread overview]
Message-ID: <u4phn17cp.fsf@gnu.org> (raw)
In-Reply-To: <46F46E9E.5070003@linux.vnet.ibm.com> (message from Carlos 	Eduardo Seo on Fri, 21 Sep 2007 22:23:42 -0300)

> Date: Fri, 21 Sep 2007 22:23:42 -0300
> From: Carlos Eduardo Seo <cseo@linux.vnet.ibm.com>
> 
> I noticed that the TUI signal handler isn't initialized anywhere. Here's
> a patch to fix it.

Thanks.

> What do you think?

I think it shouldn't use sigaction unconditionally, as the rest of GDB
doesn't.  It should at least test HAVE_SIGACTION and include an
alternative solution for when sigaction is not available.  See
remote-fileio.c for an example.


  reply	other threads:[~2007-09-22  7:34 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-22  1:24 Carlos Eduardo Seo
2007-09-22  7:34 ` Eli Zaretskii [this message]
2007-09-22 10:44 ` Pedro Alves
2007-09-22 17:13   ` Carlos Eduardo Seo
2007-09-22 18:30     ` Eli Zaretskii
2007-09-22 18:54     ` Pedro Alves
2007-09-22 19:23       ` Carlos Eduardo Seo
2007-09-22 23:10         ` Daniel Jacobowitz
2007-09-22 23:53           ` Carlos Eduardo Seo
2007-09-29  0:10             ` Carlos Eduardo Seo
2007-09-29  0:29               ` Daniel Jacobowitz
2007-10-02 16:51             ` Ulrich Weigand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=u4phn17cp.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=cseo@linux.vnet.ibm.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox