From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13640 invoked by alias); 22 Sep 2007 07:34:35 -0000 Received: (qmail 13629 invoked by uid 22791); 22 Sep 2007 07:34:33 -0000 X-Spam-Check-By: sourceware.org Received: from heller.inter.net.il (HELO heller.inter.net.il) (213.8.233.23) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 22 Sep 2007 07:34:31 +0000 Received: from HOME-C4E4A596F7 (IGLD-84-229-122-46.inter.net.il [84.229.122.46]) by heller.inter.net.il (MOS 3.7.3a-GA) with ESMTP id DRM46454 (AUTH halo1); Sat, 22 Sep 2007 09:34:26 +0200 (IST) Date: Sat, 22 Sep 2007 07:34:00 -0000 Message-Id: From: Eli Zaretskii To: Carlos Eduardo Seo CC: gdb-patches@sourceware.org In-reply-to: <46F46E9E.5070003@linux.vnet.ibm.com> (message from Carlos Eduardo Seo on Fri, 21 Sep 2007 22:23:42 -0300) Subject: Re: [patch] tui: initialize signal handler Reply-to: Eli Zaretskii References: <46F46E9E.5070003@linux.vnet.ibm.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-09/txt/msg00293.txt.bz2 > Date: Fri, 21 Sep 2007 22:23:42 -0300 > From: Carlos Eduardo Seo > > I noticed that the TUI signal handler isn't initialized anywhere. Here's > a patch to fix it. Thanks. > What do you think? I think it shouldn't use sigaction unconditionally, as the rest of GDB doesn't. It should at least test HAVE_SIGACTION and include an alternative solution for when sigaction is not available. See remote-fileio.c for an example.