From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28987 invoked by alias); 22 Sep 2007 18:54:02 -0000 Received: (qmail 28979 invoked by uid 22791); 22 Sep 2007 18:54:02 -0000 X-Spam-Check-By: sourceware.org Received: from ug-out-1314.google.com (HELO ug-out-1314.google.com) (66.249.92.175) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 22 Sep 2007 18:53:59 +0000 Received: by ug-out-1314.google.com with SMTP id o2so747644uge for ; Sat, 22 Sep 2007 11:53:54 -0700 (PDT) Received: by 10.66.255.7 with SMTP id c7mr5854184ugi.1190487234420; Sat, 22 Sep 2007 11:53:54 -0700 (PDT) Received: from ?62.169.106.103? ( [62.169.106.103]) by mx.google.com with ESMTPS id 34sm1763971nfu.2007.09.22.11.53.50 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 22 Sep 2007 11:53:52 -0700 (PDT) Message-ID: <46F564A4.3000407@portugalmail.pt> Date: Sat, 22 Sep 2007 18:54:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; pt-BR; rv:1.8.1.6) Gecko/20070728 Thunderbird/2.0.0.6 Mnenhy/0.7.5.0 MIME-Version: 1.0 To: Carlos Eduardo Seo CC: gdb-patches@sourceware.org, eliz@gnu.org Subject: Re: [patch] tui: initialize signal handler References: <46F46E9E.5070003@linux.vnet.ibm.com> <46F4F1D6.6060108@portugalmail.pt> <46F54D25.3050603@linux.vnet.ibm.com> In-Reply-To: <46F54D25.3050603@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-09/txt/msg00312.txt.bz2 (Eli, Apologies for misspelling you name upthread.) Carlos Eduardo Seo wrote: > Updated patch with your suggestions. > > Thanks. You shouldn't wrap the whole tui_initialize_win in ifdef SIGWINCH, but it's contents instead, else on a system without SIGWINCH, you'll get an undefined reference to tui_initialize_win. Other than that, it looks good to me, but, you'll need approval from a responsible or global maintainer. > 2007-09-22 Carlos Eduardo Seo ^^^ ^ It should be two spaces before and after the name. > > gdb/tui/tui-interp.c (tui_init): initialize > tui's SIGWINCH signal handler. > gdb/tui/tui-win.c (tui_initialize_win): new > function for initializing tui's SIGWINCH signal > handler. > gdb/tui/tui-win.h (tui_initialize_win): added Remove "gdb/" from the path of the changed files, since the path is relative to the ChangeLog file location. Add "* " in front, Capitalize the sentences and finish them with a full stop. Eg: 2007-09-22 Carlos Eduardo Seo * tui/tui-interp.c (tui_init): Initialize tui's SIGWINCH signal handler. * tui/tui-win.c (tui_initialize_win): New. function for initializing tui's SIGWINCH signal handler. * tui/tui-win.h (tui_initialize_win): Declare. Cheers, Pedro Alves