From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-50887-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 7806 invoked by alias); 22 Sep 2007 10:44:03 -0000
Received: (qmail 7798 invoked by uid 22791); 22 Sep 2007 10:44:02 -0000
X-Spam-Check-By: sourceware.org
Received: from ug-out-1314.google.com (HELO ug-out-1314.google.com) (66.249.92.174)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 22 Sep 2007 10:44:00 +0000
Received: by ug-out-1314.google.com with SMTP id o2so716449uge         for <gdb-patches@sourceware.org>; Sat, 22 Sep 2007 03:43:58 -0700 (PDT)
Received: by 10.67.119.15 with SMTP id w15mr5397124ugm.1190457838249;         Sat, 22 Sep 2007 03:43:58 -0700 (PDT)
Received: from ?88.210.76.158? ( [88.210.76.158])         by mx.google.com with ESMTPS id a1sm4265399ugf.2007.09.22.03.43.53         (version=TLSv1/SSLv3 cipher=RC4-MD5);         Sat, 22 Sep 2007 03:43:54 -0700 (PDT)
Message-ID: <46F4F1D6.6060108@portugalmail.pt>
Date: Sat, 22 Sep 2007 10:44:00 -0000
From: Pedro Alves <pedro_alves@portugalmail.pt>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; pt-BR; rv:1.8.1.6) Gecko/20070728 Thunderbird/2.0.0.6 Mnenhy/0.7.5.0
MIME-Version: 1.0
To: Carlos Eduardo Seo <cseo@linux.vnet.ibm.com>
CC: gdb-patches@sourceware.org
Subject: Re: [patch] tui: initialize signal handler
References: <46F46E9E.5070003@linux.vnet.ibm.com>
In-Reply-To: <46F46E9E.5070003@linux.vnet.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2007-09/txt/msg00296.txt.bz2

Carlos Eduardo Seo wrote:
> I noticed that the TUI signal handler isn't initialized anywhere. Here's
> a patch to fix it. I'm not sure if this is the correct file to add this,
> though.
> 
> What do you think?
> 

Thanks!  I wondered why it wouldn't resize :)

(Addicionally to Elli's remark, testing for ifdef SIGWINCH would be
a good idea too.)

I don't think tui_initialize_readline is the best place for this.

How about a new tui_initialize_win in tui-win.c, and call it from
next to where tui_initialize_readline is called in tui_init ?

Cheers,
Pedro Alves