qXfer:spu:read

qXfer:spu:read

[Daniel Jacobowitz]

You added these to the manual:

@item @samp{qXfer:spu:read}
@tab No
@tab @samp{-}
@tab Yes

@item @samp{qXfer:spu:write}
@tab No
@tab @samp{-}
@tab Yes

But there's no qSupported support for these packets - you probably
need to update remote_protocol_features also.

-- 
Daniel Jacobowitz
CodeSourcery

Re: qXfer:spu:read

[Ulrich Weigand]

Daniel Jacobowitz wrote:

> But there's no qSupported support for these packets - you probably
> need to update remote_protocol_features also.

Right - that part appears to have gotten lost.  Note that the 
corresponding qSupported support in gdbserver is already there ...

Here's the missing part.  Tested on spu-elf against gdbserver.
OK for mainline?

Bye,
Ulrich

ChangeLog:

	* remote.c (remote_protocol_features): Add qXfer:spu:read and
	qXfer:spu:write packet types.

diff -urNp gdb-orig/gdb/remote.c gdb-head/gdb/remote.c
--- gdb-orig/gdb/remote.c	2007-06-12 16:35:54.000000000 +0200
+++ gdb-head/gdb/remote.c	2007-06-13 15:19:44.375181482 +0200
@@ -2314,6 +2314,10 @@ static struct protocol_feature remote_pr
     PACKET_qXfer_features },
   { "qXfer:memory-map:read", PACKET_DISABLE, remote_supported_packet,
     PACKET_qXfer_memory_map },
+  { "qXfer:spu:read", PACKET_DISABLE, remote_supported_packet,
+    PACKET_qXfer_spu_read },
+  { "qXfer:spu:write", PACKET_DISABLE, remote_supported_packet,
+    PACKET_qXfer_spu_write },
   { "QPassSignals", PACKET_DISABLE, remote_supported_packet,
     PACKET_QPassSignals },
 };


-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com

Re: qXfer:spu:read

[Daniel Jacobowitz]

On Wed, Jun 13, 2007 at 04:17:56PM +0200, Ulrich Weigand wrote:
> Daniel Jacobowitz wrote:
> 
> > But there's no qSupported support for these packets - you probably
> > need to update remote_protocol_features also.
> 
> Right - that part appears to have gotten lost.  Note that the 
> corresponding qSupported support in gdbserver is already there ...
> 
> Here's the missing part.  Tested on spu-elf against gdbserver.
> OK for mainline?

Yes, thanks for fixing it!

-- 
Daniel Jacobowitz
CodeSourcery

Re: qXfer:spu:read

[Ulrich Weigand]

Daniel Jacobowitz wrote:
> On Wed, Jun 13, 2007 at 04:17:56PM +0200, Ulrich Weigand wrote:
> > Daniel Jacobowitz wrote:
> > 
> > > But there's no qSupported support for these packets - you probably
> > > need to update remote_protocol_features also.
> > 
> > Right - that part appears to have gotten lost.  Note that the 
> > corresponding qSupported support in gdbserver is already there ...
> > 
> > Here's the missing part.  Tested on spu-elf against gdbserver.
> > OK for mainline?
> 
> Yes, thanks for fixing it!

Committed, thanks.

Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com